Skip to content

test(sprint7): fix flaky DecisionsPanel highlight test - #62

Merged
Heer64 merged 1 commit into
mainfrom
fix/sprint7-flaky-decision-test
Nov 19, 2026
Merged

Heer64 merged 1 commit into
mainfrom
fix/sprint7-flaky-decision-test

Conversation

@SumitGauswami

Copy link
Copy Markdown
Collaborator

Sprint 7 — F2 Flaky Test Fix

What this PR does

Fixes an intermittent timing failure in DecisionsPanel.highlight.test.jsx.

Problem

The test sometimes checked whether scrollIntoView() was called before the asynchronous scrolling effect had completed.

Changes

  • Added waitFor from React Testing Library.
  • Waits for the expected scroll call instead of checking immediately.
  • No production application code changed.

Verification

  • Before fix: 1 failure in 10 runs.
  • After fix: 10/10 runs passed (20/20 test executions).

Merge Priority

Sprint 7 T1 — F2: Merge this PR first so the repository owner can enable required CI checks through branch protection on main.

@vercel

vercel Bot commented Nov 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
devorbit Ready Ready Preview Nov 19, 2026 12:00pm UTC

@SumitGauswami
SumitGauswami marked this pull request as draft November 19, 2026 12:24
@SumitGauswami
SumitGauswami marked this pull request as ready for review November 19, 2026 13:26
@Heer64
Heer64 merged commit 4a7d72c into main Nov 19, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants