Repository navigation
fix(postprocess): enforce container provenance in stationary move check - #247
Merged
Merged
Conversation
When code deletions shift lines up, elements in a different container can land on the exact row and column where an old element used to be. isStationaryMove previously checked only row and column coordinates within the enclosing scope, treating cross-container moves as stationary and dropping their move highlights. Require that dstParent's source mapping actually contained the node (and vice versa) before treating matching coordinates as stationary. - postprocess: check container provenance in isStationaryMove - tests: add regression test for cross-container coordinate collision
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
isStationaryMoveonly checked coordinates within the enclosing function. Because the line and column numbers matched, it assumed the node never moved and dropped the move highlight entirely.What Changed
isStationaryMoveso direct parent checks and stationary expression moves are evaluated in the right order.internal/postprocess/normalize_test.gowhere an item moves between two slice literals and lands on the exact same row and column coordinates.