Repository navigation
fix(engine): prioritize direct parent match over ancestor fallback - #246
Merged
Merged
Conversation
When two candidate pairs compete, a candidate with zero direct parent similarity could fall back to an enclosing construct like an outer loop. If that outer loop had high similarity, taking half of it could outscore a candidate with genuine direct parent similarity, stealing the match. - engine: track isFallback on scoredPair and rank direct parent matches ahead of ancestor fallbacks in slices.SortStableFunc - tests: add TestTopDown_DirectParentPrecedenceOverFallback covering direct parent priority over outer construct fallbacks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TopDownranks candidate matches, any candidate with zero direct parent similarity falls back to an outer construct like a loop or function and takes half of its score.What Changed
isFallbackon candidate pairs ininternal/engine/top-down.go, and only set it when the fallback construct actually matches.slices.SortStableFunc, make sure a candidate with a real direct parent match (dice > 0) always beats a fallback candidate before comparing raw Dice scores.TestTopDown_DirectParentPrecedenceOverFallbackininternal/engine/topdown_test.goto test that direct parent matches win over high-scoring outer loops.