Repository navigation
feat(renderutil): color move_update tokens as underlined updates - #244
Merged
Merged
Conversation
Tokens modified inside moved blocks previously rendered in their slot move color (teal or mauve). They now render in bold underlined amber so edits stand out immediately while keeping their moved context visible. Since both move slots share the same style now, ActionMoveUpdate1 is no longer needed and has been removed. - renderutil: render ActionMoveUpdate using Bold+Underline+UpdateFg - color: drop ActionMoveUpdate1 and map all slot updates to ActionMoveUpdate - tests: add table-driven coverage for move_update rendering across slots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ActionMoveUpdateandActionMoveUpdate1) purely to track the two move slot colors. Now that all inner edits use update amber anyway, keeping two kinds madeappendTransitiontreat them as different styles, spitting out unnecessary ANSI resets between adjacent spans.What Changed
ActionMoveUpdatein bold underlined amber (Bold + Underline + UpdateFg). Edits inside moves now pop out as actual updates while the underline shows they moved.ActionMoveUpdate1frominternal/color/color.goand simplifiedMoveActionKindForSlotso all updates returnActionMoveUpdate.TestSlicer_MoveUpdate_Stylingto a table-driven test covering both move slots and dropped the redundant inline comments.