Repository navigation
fix(postprocess): demote hollow composite moves after eviction - #243
Merged
Merged
Conversation
When an outer container move (like an if statement) is demoted to delete+insert, its inner tokens get evicted. Inner composite nodes with their own explicit move (such as a condition's binary_expression) were surviving even after every payload leaf was wiped out, leaving an empty move shell that highlighted destination tokens in move color while deleting the source side. Demote composite moves to delete+insert when all of their mapped leaves were evicted by an ancestor demotion cascade. - postprocess: demote composite moves whose mapped leaves were all evicted - postprocess: evaluate unevicted leaves first to short-circuit the hot path - tests: verify hollow binary_expression moves are demoted after eviction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
binary_expression) had its own Move action, it slipped past our hollow container checks because those only ran on blocks or delimited containers like{}or().What Changed
shouldDemoteMove, check if a composite node had mapped payload leaves that all got evicted by an ancestor demotion cascade, and demote it to Delete and Insert too.internal/postprocess/normalize_test.goto make sure condition expressions inside demoted control flow don't hang around as hollow moves.