Skip to content

Prepare uphold 1.25.0 - #297

Merged
HackingGate merged 1 commit into
mainfrom
prepare-1.25.0
Oct 3, 2026
Merged

HackingGate merged 1 commit into
mainfrom
prepare-1.25.0

Conversation

@HackingGate

@HackingGate HackingGate commented Oct 3, 2026 •

Copy link
Copy Markdown
Owner

Three engine changes since 1.24.0. A rule whose files.include root is not
on disk no longer selects nothing, prints one line on stderr and passes: the
scan exits 2 naming the rule, the root and that the root does not exist. This
holds for every rule, bundled sets included, so a repository that inherits
default-token-grant and has no .github/workflows is now refused (#294).

The relative-link check removes inline code spans from each line before it
reads links, delimited as CommonMark does: a run of N backticks closes at the
next run of exactly N, and an unmatched run stays literal. A regular
expression in backticks such as [2-9](\.\d+) is no longer reported as a
link to a missing file (#295).

A remote counts as GitHub only when its host is github.com, www.github.com or
raw.githubusercontent.com, the one definition private-names and the shim
already used. A GitHub Enterprise remote is no longer asked about on
github.com: unowned-push keeps the allow-list's refusal for it with exit 1,
and the shim's visibility lookup reports could-not-tell. Any other unknown
forge is refused as before. A remote URL's host now ends at the first /, ?
or #, and userinfo is stripped up to the last @, so
https://evil.com#@github.com/acme/widget.git is read as evil.com, which is
where git pushes, and unowned-push no longer accepts it on the strength of
github.com ownership. Two spellings uphold cannot read the way git does now
name no host and no repository, so unowned-push refuses them as an unreadable
destination: a % anywhere in a scheme:// URL's authority and a [ in a
scp-like host. A file:// URL names no host, so it is never asked about on a
forge, and its repository is read from the path like a plain local path, so
the allow-list judges it by its path (#296).

encoding_rs is 0.8.42 (#281), and CI runs astral-sh/setup-uv 10.2.0 (#280).

A consumer taking the pin to v1.25.0 must have every files.include root its
rules name on disk, inherited sets included: a missing root now fails the scan
with exit 2 where it warned, and the fix is to correct the root or remove it.
A consumer pushing to a GitHub Enterprise remote that its allow-list does not
name is now refused where github.com may have answered for it. An ssh Host
alias such as git@github-work:me/repo, or ssh.github.com:443, is no longer
counted as GitHub, so a push through one to a destination the allow-list does
not name is refused; name the destination in the allow-list, or use a
github.com URL. A push through a remote URL carrying a percent-encoded
credential is refused whatever the allow-list names; drop the encoded
credential from the URL.

@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 19 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8a1badb3-ee93-4ad5-a975-cadaa7ea4941
📥 Commits

Reviewing files that changed from the base of the PR and between 71eab39 and 084d44e.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • Cargo.toml
  • README.md
  • hooks/lefthook.yml
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

codecov-commenter commented Oct 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.09%. Comparing base (d8c43eb) to head (084d44e).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
+ Coverage   94.04%   94.09%   +0.04%     
==========================================
  Files          46       46              
  Lines       20868    20991     +123     
==========================================
+ Hits        19626    19752     +126     
+ Misses       1242     1239       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Three engine changes since 1.24.0. A rule whose `files.include` root is not
on disk no longer selects nothing, prints one line on stderr and passes: the
scan exits 2 naming the rule, the root and that the root does not exist. This
holds for every rule, bundled sets included, so a repository that inherits
`default-token-grant` and has no `.github/workflows` is now refused (#294).

The relative-link check removes inline code spans from each line before it
reads links, delimited as CommonMark does: a run of N backticks closes at the
next run of exactly N, and an unmatched run stays literal. A regular
expression in backticks such as `[2-9](\.\d+)` is no longer reported as a
link to a missing file (#295).

A remote counts as GitHub only when its host is github.com, www.github.com or
raw.githubusercontent.com, the one definition private-names and the shim
already used. A GitHub Enterprise remote is no longer asked about on
github.com: unowned-push keeps the allow-list's refusal for it with exit 1,
and the shim's visibility lookup reports could-not-tell. Any other unknown
forge is refused as before (#296).

encoding_rs is 0.8.42 (#281), and CI runs astral-sh/setup-uv 10.2.0 (#280).

A consumer taking the pin to v1.25.0 must have every `files.include` root its
rules name on disk, inherited sets included: a missing root now fails the
scan with exit 2 where it warned, and the fix is to correct the root or remove
it. A consumer pushing to a GitHub Enterprise remote that its allow-list does
not name is now refused where github.com may have answered for it.
@HackingGate
HackingGate merged commit 0323ada into main Oct 3, 2026
13 checks passed
@HackingGate
HackingGate deleted the prepare-1.25.0 branch October 3, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants