Repository navigation
fix: store release blockers - iOS icon alpha, Play feature graphic, release permissions, bundle id - #27
Merged
Conversation
…elease permissions, bundle id - assets/ios-icon-1024.png: drop the alpha channel App Store Connect rejects. Every pixel was already opaque, so the image is pixel-identical. - assets/play-feature-graphic-1024x500.png: new Play feature graphic (lockup centered on cream, 24-bit PNG, no alpha). Rebuild command in assets/README.txt. - app.json android.blockedPermissions: release builds drop INTERNET, SYSTEM_ALERT_WINDOW, READ/WRITE_EXTERNAL_STORAGE. plugins/withDebugOnlyInternet re-adds INTERNET to the debug and debugOptimized manifests so dev builds still reach Metro. - ios.bundleIdentifier: com.htpdevs.birthmark, matching Android. Verified: Gradle merged manifests (release has no INTERNET; debug variants do), release APK on an emulator records a session and exports the PDF with no INTERNET permission. tests/storeAssets.test.ts fails on the old icon. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the store release blockers found in the release audit.
What changed
assets/ios-icon-1024.png): removed the alpha channel, which App Store Connect rejects. Every pixel was already opaque, so the image looks the same (magick compare: 0 differing pixels).assets/play-feature-graphic-1024x500.png): new. The lockup is centered on cream; 24-bit PNG with no alpha. The rebuild command is inassets/README.txt.app.jsonandroid.blockedPermissions): removesINTERNET,SYSTEM_ALERT_WINDOW,READ_EXTERNAL_STORAGEandWRITE_EXTERNAL_STORAGE. The newplugins/withDebugOnlyInternet.jsaddsINTERNETback in thedebuganddebugOptimizedmanifests so dev builds can still load from Metro.com.htpdevs.birthmark, the same as Android.How it was tested
npx jest: 227 passed before the critic follow-ups. After them, the touched suites passed (debugOnlyInternet8/8).npm run typecheckandnpm run lintare clean.tests/storeAssets.test.tsreads the PNG headers to check that the icon has no alpha and that the feature graphic is 1024x500 RGB. It fails on the old icon (checked).tests/debugOnlyInternet.test.tschecks the plugin against a tempandroid/tree, including repeat prebuilds and a missing manifest. It also pins the exact blocked list.VIBRATE,ACCESS_NETWORK_STATEand the app's own receiver permission. The debug and debugOptimized manifests keepINTERNET.INTERNETpermission granted, records a session and exports the PDF ("PDF ready").Not in this PR
ACCESS_NETWORK_STATEremains. It comes from a Maven AAR, it is a normal permission, and blocking it could throwSecurityExceptionat runtime.app.json.🤖 Generated with Claude Code