Skip to content

fix: store release blockers - iOS icon alpha, Play feature graphic, release permissions, bundle id - #27

Merged
dsatpm merged 1 commit into
mainfrom
dsatpm/store-release-fixes-80e04f4d
Oct 10, 2026
Merged

dsatpm merged 1 commit into
mainfrom
dsatpm/store-release-fixes-80e04f4d

Conversation

@dsatpm

@dsatpm dsatpm commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

Fixes the store release blockers found in the release audit.

What changed

  • iOS icon (assets/ios-icon-1024.png): removed the alpha channel, which App Store Connect rejects. Every pixel was already opaque, so the image looks the same (magick compare: 0 differing pixels).
  • Play feature graphic (assets/play-feature-graphic-1024x500.png): new. The lockup is centered on cream; 24-bit PNG with no alpha. The rebuild command is in assets/README.txt.
  • Release Android permissions (app.json android.blockedPermissions): removes INTERNET, SYSTEM_ALERT_WINDOW, READ_EXTERNAL_STORAGE and WRITE_EXTERNAL_STORAGE. The new plugins/withDebugOnlyInternet.js adds INTERNET back in the debug and debugOptimized manifests so dev builds can still load from Metro.
  • iOS bundle id: com.htpdevs.birthmark, the same as Android.

How it was tested

  • npx jest: 227 passed before the critic follow-ups. After them, the touched suites passed (debugOnlyInternet 8/8). npm run typecheck and npm run lint are clean.
  • New tests/storeAssets.test.ts reads the PNG headers to check that the icon has no alpha and that the feature graphic is 1024x500 RGB. It fails on the old icon (checked).
  • New tests/debugOnlyInternet.test.ts checks the plugin against a temp android/ tree, including repeat prebuilds and a missing manifest. It also pins the exact blocked list.
  • Prebuild plus Gradle manifest merge: the release manifest's permissions are now VIBRATE, ACCESS_NETWORK_STATE and the app's own receiver permission. The debug and debugOptimized manifests keep INTERNET.
  • A release APK on an Android 16 emulator, with no INTERNET permission granted, records a session and exports the PDF ("PDF ready").

Not in this PR

  • ACCESS_NETWORK_STATE remains. It comes from a Maven AAR, it is a normal permission, and blocking it could throw SecurityException at runtime.
  • The iOS privacy manifest is not declared in app.json.

🤖 Generated with Claude Code

…elease permissions, bundle id

- assets/ios-icon-1024.png: drop the alpha channel App Store Connect rejects.
  Every pixel was already opaque, so the image is pixel-identical.
- assets/play-feature-graphic-1024x500.png: new Play feature graphic (lockup
  centered on cream, 24-bit PNG, no alpha). Rebuild command in assets/README.txt.
- app.json android.blockedPermissions: release builds drop INTERNET,
  SYSTEM_ALERT_WINDOW, READ/WRITE_EXTERNAL_STORAGE. plugins/withDebugOnlyInternet
  re-adds INTERNET to the debug and debugOptimized manifests so dev builds still
  reach Metro.
- ios.bundleIdentifier: com.htpdevs.birthmark, matching Android.

Verified: Gradle merged manifests (release has no INTERNET; debug variants do),
release APK on an emulator records a session and exports the PDF with no
INTERNET permission. tests/storeAssets.test.ts fails on the old icon.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dsatpm
dsatpm merged commit fb7b4d3 into main Oct 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant