Repository navigation
fix(connect-a-wallet-widget): harden wallet flows and QA (#245) - #249
Open
edehvictor wants to merge 1 commit into
Open
edehvictor wants to merge 1 commit into
edehvictor wants to merge 1 commit into
Conversation
edehvictor
marked this pull request as ready for review
October 13, 2026 16:41
This was referenced Oct 13, 2026
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #245. Follow-up to #116, targeting
plan/connect-a-wallet-widget.Changes
Verification
pnpm test:demo tests/widgets/connect-a-wallet-widget --workers=1 --retries=0: 27/27 passed, exit 0.pnpm buildandpnpm lintremain blocked by the existing UISelect.tsx:7Role type error, reproduced from unchanged base commit3ce69ab6.Evidence And Limits
Details: QA report.
Evidence: screenshots, including automated desktop/mobile states and a separately labeled manual Celo screenshot.
42220, which shared core parsed as hexadecimal. The shared-core correction is not included outside this issue's scope. These results do not establish unmodified WalletConnect compatibility.Implementation commit:
074b54799578d08c1c50a492c53061397efd9fd0(GPG-signed).