Display package version label in all widgets (#236) by Copilot · Pull Request #237 · GoodDollar/GoodWidget

Copilot · 2026-10-06T11:16:47Z

Fixes #236.

Adds a muted, right-aligned WidgetVersion row using each widget package’s named version import from its own package.json. The row renders below content in normal flow and adds height. Future-widget instructions document the requirement.

Focused follow-up (`51d0273`)

Remove the GovernanceOnboardingWidget label while retaining GovernanceWidget’s package version.
Preserve CitizenClaim and Superfluid Campaign labels and explain intentional embedded labels in the review thread.
Correct the normal-flow layout wording to state that the row adds height.
Run existing checks and desktop/mobile, light/dark QA; commit updated screenshot evidence and summarize results.

Only two source files and QA images changed in this follow-up. No automated tests, stories, or testing infrastructure were added or changed.

QA evidence

Chromium; desktop 1280×900, mobile 430×932. All displayed labels matched the package versions below. Measured rows remained below their preceding content, with label bounds inside each row and viewport; no version-row clipping or overlap observed. Governance onboarding has one label. Embedded claim deliberately shows both packages’ labels.

36 screenshots, tracked in the existing per-widget test-results flow. The links below open each package’s evidence folder; latest captures are named version-<state>-<desktop|mobile>-<light|dark>.png.

Package	Displayed version	Captured states/themes (both widths)	Screenshots
AI Credits	`v0.1.8`	Disconnected, dark	Evidence
CitizenClaim	`v0.2.1`	Custodial, dark; embedded light/dark below	Evidence
Claim theme demo	`v0.1.0`	Showcase, light/dark	Evidence
GoodData	`v0.1.0`	Existing analytics app dashboard, dark	Evidence
GoodReserve	`v0.1.7`	Quote ready, light/dark	Evidence
Governance	`v0.1.0`	Onboarding light; dashboard light/dark	Evidence
Staking migration	`v0.1.0`	Ready, light/dark	Evidence
Streaming	`v0.1.0-beta`	Populated, light/dark	Evidence
Superfluid Campaign	`v0.1.6` (plus CitizenClaim `v0.2.1` when embedded)	Content and embedded claim, light/dark	Evidence

AI Credits’ existing disconnected fixture and GoodData’s app host hard-code dark presentation; no light-mode coverage is claimed for those demos. CitizenClaim light presentation was checked within the existing Campaign showcase. No demos were modified to expand coverage.

Mobile onboarding: one governance label

Mobile embedded claim: intentional independent versions

Validation

Seven existing package-version Playwright tests passed.
Existing Campaign embedded-claim open/close test passed.
Governance package build passed; ESLint on both edited files passed; git diff --check passed.
Full governance lint remains blocked by existing unrelated unused variables (widgetBounds in GovernanceWidget and ProfileTextAreaField in ProfileStepContent); left untouched.
Secret scan passed. Read-only review found no significant issues. Parallel validation’s automated review executable was unavailable; CodeQL skipped the trivial presentational changes.

Copilot

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

Co-authored-by: sirpy <671095+sirpy@users.noreply.github.com>

sirpy

import only {version} from package.json instead of the whole file
add tests to verify version text exists in the ui

sirpy · 2026-10-07T12:49:16Z

import only {version} from package.json instead of the whole file

add tests to verify version text exists in the ui

@copilot

Copilot

🟡 Changes recommended

Composite widgets render duplicate labels, and required Storybook and screenshot evidence is incomplete.

13 open findings

🧠 Review effort: Balanced

      defaultTheme={defaultTheme}
    >
      <ClaimInner />
+      <WidgetVersion version={version} />


            <Route path="*" element={<UnknownDashboardPage />} />
          </Routes>
        </BrowserRouter>
+        <WidgetVersion version={version} />


Copilot · 2026-10-13T07:22:42Z

      ) : (
        <DefaultGovernanceWidgetContent adapterInput={adapterInput} testId={testId} />
      )}
+      <WidgetVersion version={version} />


Removed the label and unused imports from GovernanceOnboardingWidget in 51d0273. GovernanceWidget retains its package-version label; existing onboarding QA now displays exactly one v0.1.0 row.

Copilot · 2026-10-13T07:22:42Z

        />
      </Card>
      <ToastContainer />
+      <WidgetVersion version={version} />


Both labels are intentional per the focused follow-up: each widget package displays its own version even when embedded. CitizenClaim retains v0.2.1 and Superfluid Campaign retains v0.1.6. Desktop/mobile light/dark embedded-claim screenshots in 51d0273 confirm both rows sit below their respective content without overlapping.

+ * It sits in normal flow below the widget content (right-aligned) so it never
+ * overlaps or shifts the widget layout.
+ */
+export function WidgetVersion({ version, testId = 'widget-version' }: WidgetVersionProps) {


+
+test('GoodReserveWidget displays its package version', async ({ page }) => {
+  await page.goto('/iframe.html?id=widgets-goodreservewidget--interactive&viewMode=story')
+  await expect(page.getByTestId('widget-version')).toHaveText(`v${version}`, { timeout: 20_000 })


+  await page.goto(
+    '/iframe.html?id=qa-governancewidget-runtime-fixtures--disconnected-dashboard&viewMode=story',
+  )
+  await expect(page.getByTestId('widget-version')).toHaveText(`v${version}`, { timeout: 20_000 })


+  await page.goto(
+    '/iframe.html?id=qa-stakingmigrationwidget-runtime-fixtures--ready&viewMode=story',
+  )
+  await expect(page.getByTestId('widget-version')).toHaveText(`v${version}`, { timeout: 20_000 })


+  await page.goto(
+    '/iframe.html?id=qa-streamingwidget-runtime-fixtures--populated-state&viewMode=story',
+  )
+  await expect(page.getByTestId('widget-version')).toHaveText(`v${version}`, { timeout: 20_000 })


+  await page.goto(
+    '/iframe.html?id=qa-superfluidcampaignwidget-runtime-fixtures--no-wallet-content&viewMode=story',
+  )
+  await expect(page.getByTestId('widget-version')).toHaveText(`v${version}`, { timeout: 20_000 })


L03TJ3 · 2026-10-13T07:14:50Z

Focused follow-up for #237

Remove the duplicate version label from GovernanceOnboardingWidget. Keep the package version displayed by GovernanceWidget.
Display package version label in all widgets (#236) #237 (comment)
Keep each widget package’s own version label, including when embedded in another widget. CitizenClaim and Superfluid Campaign should both retain theirs. Reply to the related review comment explaining that this is intentional.
Display package version label in all widgets (#236) #237 (comment)
Using the existing demos and QA setup, sanity-check the displayed versions against their package versions. Check desktop/mobile and light/dark presentation, and produce updated screenshots as part of the test-results flow.
Confirm the added row does not clip or overlap content.
Correct the comment claiming the label “never shifts layout”: it renders below the content and adds height.
Display package version label in all widgets (#236) #237 (comment)

No new automated test coverage, stories or testing infrastructure is required for this patch.
Keep changes limited to the duplicate label, wording and QA evidence.
@copilot

…idence (#236) Co-authored-by: L03TJ3 <6606028+L03TJ3@users.noreply.github.com>

Copilot · 2026-10-13T07:22:43Z

Focused follow-up for #237

Remove the duplicate version label from GovernanceOnboardingWidget. Keep the package version displayed by GovernanceWidget.
...

Addressed in 51d0273: removed the onboarding duplicate, corrected layout wording, and preserved both intentional embedded package labels. Added 36 QA screenshots across all nine packages at 1280×900 and 430×932, including light/dark pairs where existing demos expose them. Versions match package.json; checked rows remain below content without clipping/overlap. AI Credits’ fixture and GoodData’s host are dark-only. Seven existing version tests plus the embedded-claim open/close test, governance build, and edited-file ESLint passed. Full governance lint still reports unrelated existing unused-variable errors. No tests, stories, or infrastructure added.

Copilot

🔵 Needs a closer look

Screenshot evidence is not reproducible by committed tests, two integrations lack assertions, and the new primitive lacks required Storybook coverage.

12 open findings

1 resolved since last review

Normal-flow row increases widget layout height

🧠 Review effort: Balanced

Initial plan

3b9077c

Copilot AI assigned Copilot and sirpy Oct 6, 2026

Copilot AI balanced review requested due to automatic review settings October 6, 2026 11:16

Copilot AI reviewed Oct 6, 2026

View reviewed changes

Copilot started work on behalf of sirpy October 6, 2026 11:17 View session

Copilot AI linked an issue Oct 6, 2026 that may be closed by this pull request

Display widget version in it's UI #236

Open

Copilot AI and others added 2 commits October 6, 2026 11:25

feat: display widget version in all widgets

28667dc

Co-authored-by: sirpy <671095+sirpy@users.noreply.github.com>

Apply remaining changes

85089b2

Co-authored-by: sirpy <671095+sirpy@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add widget version display in UI~~ Display package version label in all widgets Oct 6, 2026

Copilot AI requested a review from sirpy October 6, 2026 11:25

Copilot finished work on behalf of sirpy October 6, 2026 11:25

Copilot AI had a problem deploying to internal October 6, 2026 14:52 Error

Copilot AI deployed to internal October 6, 2026 14:52 Active

Copilot AI deployed to preview-superfluid-campaign October 6, 2026 14:52 View deployment

Copilot AI deployed to preview-gooddata October 6, 2026 14:52 View deployment

Copilot AI deployed to preview-ai-credits October 6, 2026 14:52 View deployment

Copilot AI deployed to internal October 6, 2026 14:52 Active

Copilot AI deployed to preview-storybook October 6, 2026 14:52 View deployment

sirpy requested changes Oct 7, 2026

View reviewed changes

Copilot started work on behalf of sirpy October 7, 2026 10:50 View session

Copilot finished work on behalf of sirpy October 7, 2026 10:53

Copilot AI requested a review from sirpy October 7, 2026 10:53

Copilot started work on behalf of sirpy October 7, 2026 12:50 View session

sirpy deployed to internal October 7, 2026 13:06 — with GitHub Actions Active

sirpy deployed to preview-ai-credits October 7, 2026 13:06 — with GitHub Actions View deployment

sirpy deployed to preview-gooddata October 7, 2026 13:06 — with GitHub Actions View deployment

sirpy deployed to preview-storybook October 7, 2026 13:06 — with GitHub Actions View deployment

sirpy deployed to preview-superfluid-campaign October 7, 2026 13:06 — with GitHub Actions View deployment

sirpy approved these changes Oct 7, 2026

View reviewed changes

sirpy requested review from L03TJ3 and a balanced review from Copilot October 7, 2026 13:07

Copilot started reviewing on behalf of sirpy October 12, 2026 08:28 View session

Copilot AI reviewed Oct 12, 2026

View reviewed changes

sirpy self-requested a review October 12, 2026 08:35

sirpy approved these changes Oct 12, 2026

View reviewed changes

L03TJ3 mentioned this pull request Oct 13, 2026

fix(gooddata-widget): AI Credits dashboard display, labeling, and scale fixes #227

Open

Copilot started work on behalf of L03TJ3 October 13, 2026 07:15 View session

fix: remove governance onboarding version duplicate and refresh QA ev…

51d0273

…idence (#236) Co-authored-by: L03TJ3 <6606028+L03TJ3@users.noreply.github.com>

L03TJ3 changed the title ~~Display package version label in all widgets~~ Display package version label in all widgets (#236) Oct 13, 2026

L03TJ3 deployed to internal October 13, 2026 07:23 — with GitHub Actions Active

L03TJ3 deployed to preview-gooddata October 13, 2026 07:23 — with GitHub Actions View deployment

L03TJ3 deployed to preview-superfluid-campaign October 13, 2026 07:23 — with GitHub Actions View deployment

L03TJ3 deployed to preview-storybook October 13, 2026 07:23 — with GitHub Actions View deployment

L03TJ3 deployed to preview-ai-credits October 13, 2026 07:23 — with GitHub Actions View deployment

Copilot finished work on behalf of L03TJ3 October 13, 2026 07:24

sirpy requested a balanced review from Copilot October 14, 2026 12:27

Copilot started reviewing on behalf of sirpy October 14, 2026 12:28 View session

Copilot AI reviewed Oct 14, 2026

View reviewed changes

Navigation Menu

Repository navigation

Display package version label in all widgets (#236) - #237

Display package version label in all widgets (#236)#237
sirpy with Copilot wants to merge 5 commits into
mainfrom
copilot/add-version-text-to-widgets

Copilot AI commented Oct 6, 2026 •

edited by L03TJ3

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

sirpy left a comment

Uh oh!

sirpy commented Oct 7, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Oct 13, 2026

Uh oh!

Copilot AI Oct 13, 2026

Uh oh!

L03TJ3 commented Oct 13, 2026

Uh oh!

Copilot AI commented Oct 13, 2026

Focused follow-up for #237

Uh oh!

Copilot AI left a comment

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Copilot AI commented Oct 6, 2026 • edited by L03TJ3 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Focused follow-up (51d0273)

QA evidence

Mobile onboarding: one governance label

Mobile embedded claim: intentional independent versions

Validation

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

sirpy left a comment

Choose a reason for hiding this comment

Uh oh!

sirpy commented Oct 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Copilot AI Oct 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 13, 2026

Choose a reason for hiding this comment

Uh oh!

L03TJ3 commented Oct 13, 2026

Focused follow-up for #237

Uh oh!

Copilot AI commented Oct 13, 2026

Focused follow-up for #237

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Oct 6, 2026 •

edited by L03TJ3

Loading

Focused follow-up (`51d0273`)