Repository navigation
fix: account for effective global.json in release planning - #35
Merged
Merged
Conversation
[Medium impact] The PR appears safe to merge; the previous path-casing issue is fixed and no new blocking issues were found.
|
…fix/effective-global-json # Conflicts: # src/PackageCascade.Tests.Integration/CoreOnly/Planning/PlannerIntegrationTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
global.jsonthat can select the SDK for the solution's build working directory.global.jsonat each commit so a later nested file cannot hide an earlier ancestor SDK change; keep shadowed ancestor changes from triggering shared bumps.global.jsonpaths using the platform's case rules, so valid Windows solution paths retain the correct SDK selection.Verification
PackageCascade.Tests.Unitwith--no-restoreand passed 65 focused planning tests for SDK selection and release planning.PackageCascade.Tests.Integrationand passed the focused historicalglobal.jsonregression after merging the expanded test fixtures.dotnet format --verify-no-changeschecks andgit diff --check.Some local restores and builds reported
NU1900because the sandbox could not reach NuGet's vulnerability feed; the focused builds and tests still succeeded.