Skip to content

feat: diagnose alias collisions and invalid English exponents - #34

Merged
ScottishTapWater merged 1 commit into
feat/quantity-alias-codefixfrom
feat/generation-diagnostics
Oct 24, 2026
Merged

feat: diagnose alias collisions and invalid English exponents#34
ScottishTapWater merged 1 commit into
feat/quantity-alias-codefixfrom
feat/generation-diagnostics

Conversation

@ScottishTapWater

@ScottishTapWater ScottishTapWater commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

Summary

Third PR in the analyser stack; based on #33.

  • Add DQ0006 warnings for generated aliases that conflict with declarations or explicit aliases, or displace imported types, including metadata types and static member uses.
  • Preserve existing alias generation and binding behaviour.
  • Add DQ0007 errors for invalid unresolved English exponent requests on the library's Power<T>.Of API, while respecting bound names and unrelated APIs.
  • Share planned alias names with the emitter and keep diagnostic discovery in focused helpers.
  • Cover collisions, unchanged binding, cross-file alias scope, invalid requests, and diagnostic removal after edits.

Verification

  • Full solution test suite passed, including package integration and quick-fix tests.
  • Formatting verification and git diff --check passed.
  • Independent C# review completed; findings fixed and reviewed again.

@ScottishTapWater ScottishTapWater mentioned this pull request Oct 24, 2026
Merged
@ScottishTapWater
ScottishTapWater merged commit 2de3bf4 into main Oct 24, 2026
2 checks passed
@ScottishTapWater
ScottishTapWater deleted the feat/generation-diagnostics branch October 24, 2026 20:38
ScottishTapWater added a commit that referenced this pull request Oct 24, 2026
@ScottishTapWater
docs: describe analyser diagnostics and alias quick fix (#35)
c2c4eca 
## Summary

Documentation follow-up stacked on #34.

- Describe the bundled analysers and alias quick fix.
- Summarise DQ0001–DQ0007, including severities.
- Explain safe alias replacement and collision warning behaviour.
- Remove the outdated statement that diagnostics and IDE fixes are
future work.

## Verification

- Checked descriptions against the diagnostic implementations and
code-fix provider.
- Independent documentation review.
- `git diff --check` passed; documentation only, so no test rerun.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ScottishTapWater