ci(pr-validation): shallow checkouts and scoped app.validate - #118
Merged
Merged
Conversation
The PR validation comment cloned TechAPI's full history twice (head and base) and ran app.validate over every record. Check both out at depth 1, deepen the head only to the merge base, fetch the pinned base at depth 1, and validate just the changed records. integrity_check still scans both trees; it is population-based and needs its own scoping. Refs GetTechAPI/TechAPI#350
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 6 of GetTechAPI/TechAPI#350 (replaces the deploy-pages idea: that job only runs on main pushes, this one runs on every TechAPI PR).
fetch-depth: 0->1; head deepened to depth 100 for the merge base (unshallow fallback); pinned base fetched at depth 1.app.validate->--changed-since $TECHAPI_DIFF_BASE.integrity_check.pystill scans both full trees (its checks are population-based, e.g. MAD outliers), and the site-change detector still walks site/. Both are follow-ups.