feat(data): add 1 smartphone from manufacturer Wikipedia pages - #328
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds iPhone Duo, the only complete missing smartphone found after reconciling three live manufacturer Wikipedia pages against existing names, slugs and base-model variants.
Apple: 55 comparison-column models, 54 existing and Duo absent. The raw gaps comprise 208 non-model cells, 22 existing grouped/generation aliases, and Duo. Every added field is explicit in the source column: A20 Pro, 12 GB RAM, four storage options, 5400 mAh, 254 g and iOS 27.1. Its stated 2026-10-23 release date is future; the record uses
verified: false, existingapple-a20-pro, andbase_model_slug: iphone-duo. No optional specs or benchmarks were guessed.Google: 26 table rows expand to 38 models, 34 existing and four absent Pixel 11 models. The eight raw gaps comprise three headers, two existing grouped names, and three labels representing those four models. All require Tensor G6, absent from curated SoCs; the source also lacks clear weights and has a Fold-model typo. None was added.
Samsung: the raw gaps are existing aliases/families or non-model/out-of-scope cells. Every model column in its 176-row timeline was separately checked. The timeline supplies names and month/year but no hardware specs or SoC, so it yields zero complete new rows. Unmatched source-only names remain candidates for better sources; this does not establish that the whole catalog is exhausted.
Expanded rowspan/colspan grids, read actual model columns, expanded slash groups, normalized punctuation, checked both directions and existing base-model variants, and hand-reviewed ambiguous siblings. Samples include SE generations, distinct Pro Max/Pro XL models, Beam i8530 = I8530 Galaxy Beam, Ace 2 x = Ace II X S7560M, Note Fan Edition = Note FE, and Z Fold SE = Z Fold Special Edition.
Sources: iPhone models, Pixel, Samsung Galaxy list. Live audit 2026-09-29; revisions 1377138205 / 1376853504 / 1376180026.
Validation:
python -m app.validateandgit diff --checkpassed. Added source fields, SoC FK, base model and verification flag agree with generated detail/score. Unique slugs, index and manifest agree at 93,408 smartphones / 93,408 scored. The final commit refreshes the smartphone dump through TechEngine serializers; existing detail pages are unchanged and new performance scores remain null.Closes #295