Repository navigation
feat(MessageComposer): make composer previews a configurable set #3365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MartinCupela
wants to merge
18
commits into
master
Choose a base branch
from
feat/composable-composer-previews
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,428
−223
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
93adb3c
feat(MessageComposer): make composer previews a configurable set and …
MartinCupela 699b505
chore(examples): configure the composer's preview sections in the vit…
MartinCupela 1a2b13c
feat(Poll): make the poll creation dialog footer a component slot
MartinCupela 16840bc
chore(examples): attach polls to the message while the Poll preview i…
MartinCupela b7022cf
feat(MessageComposer): show the poll's settings and a capped option l…
MartinCupela 533e610
feat(Message): make the message bubble's content a configurable set
MartinCupela b924466
chore(examples): order the message bubble's content in a new Message …
MartinCupela c46af0f
chore(examples): send the attached poll with the message's text and a…
MartinCupela 31a6a18
feat(MessageActions): let each message action carry its own visibilit…
MartinCupela 6c2435a
fix(MessageComposer): drop the edit preview's nested previews wrapper
MartinCupela 30b80ed
chore(deps): upgrate stream-chat to v10.0.0-rc.28
MartinCupela 7ce7637
fix(Message): address review findings on bubble context, poll edit ru…
MartinCupela 7962e1b
chore(deps): upgrate stream-chat to v10.0.0-rc.29
MartinCupela 82a78fa
fix(MessageComposer): detach the poll on remove without deleting it
MartinCupela 6f254c7
chore(deps): bump @stream-io/state-store to 1.2.0 to match stream-cha…
MartinCupela 6ba38ab
refactor(MessageComposer)!: move the poll preview to the vite example
MartinCupela bef2e43
docs(ai-docs): catch createPoll() failures in the attach-poll example
MartinCupela 52d1d46
Merge remote-tracking branch 'origin/master' into feat/composable-com…
MartinCupela File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge order:
createPollOnlyCompositionMiddlewareandPOLL_ONLY_COMPOSITION_MIDDLEWARE_IDexist only after GetStream/stream-chat-js#1970.yarn examples:buildruns in CI, so this needs a stream-chat release and a dependency bump before it can go green. Nothing in this diff bumpsstream-chatyet.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. GetStream/stream-chat-js#1970 is merged but came after rc.28, and
POLL_ONLY_COMPOSITION_MIDDLEWARE_IDisn't in rc.28. This PR needs rc.29 and a bump before merging.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow-up: done. 7962e1b bumps
stream-chatto 10.0.0-rc.29 (root andexamples/vite), which includes GetStream/stream-chat-js#1970 and exportsPOLL_ONLY_COMPOSITION_MIDDLEWARE_IDandcreatePollOnlyCompositionMiddleware. 6f254c7 bumps@stream-io/state-storeto 1.2.0 to match it, so there is a single copy andyarn typesis clean again.