Conversation
_forward_to_host swallowed exceptions and _handle_builtin_action /
the action-Command forwarding path in _handle_request always replied
with {'hide': True}, so a failed host call still hid the launcher
with no indication anything went wrong.
Also fix JsonRPCV2Client.messages(), which resolved the waiting
future with a plain result even when the host replied with a JSON-RPC
error, masking real host-side failures behind an apparent success.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_forward_to_host swallowed exceptions when forwarding a built-in action (Flow.Launcher.*) or an action-returned Command to the host, and callers always answered with {'hide': True} regardless of whether the forward actually succeeded. A failed host call currently just hides the launcher with no indication anything went wrong.
JsonRPCV2Client.messages() also resolved a pending request's future with a plain result even when the host replied with a JSON-RPC error, so an actual host-side failure was invisible to the caller in the first place.
_forward_to_host now reports success/failure, and a failed forward answers with {'hide': False} instead of hiding the launcher on a silent failure.
Added integration tests covering a host error reply and the stream closing before a reply arrives, both asserting {'hide': False}.