Conversation
…and workflow remount
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where Markdown notes revert to plain text / raw textarea without formatting when switching workflows, changing projects, or remounting widgets after Memory Saver unmounts them.
Cause
In
src/renderer/widgets/note/widget.tsx, theuseEffecthook responsible for initializingTinyMDEonly ran on initial mount whenisLoadedwasfalse(at which pointtextAreaRef.currentwasnull).Because
isLoadedwas missing from the hook's dependency array, the effect was never re-triggered oncedataStorage.getText()resolved and the<textarea>actually rendered into the DOM. Consequently, the Markdown visual editor failed to attach upon subsequent workflow re-renders.Solution
isLoadedto the editor'suseEffectdependency array soTinyMDEinitializes immediately after the textarea DOM node is mounted.removeExistingEditorDOM) to prevent duplicate DOM nodes or memory leaks during component unmount/remount cycles.How to Test
<textarea>.