Repository navigation
feat: allow customizing the hover background of dates - #125
Conversation
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Customizable date hover backgrounds src/main/resources/META-INF/frontend/fc-month-calendar/vaadin-month-calendar.css, src/test/resources/META-INF/frontend/styles/test_year-month-calendar.css, README.md, pom.xml |
The hover rule uses --hover-background-color before existing theme fallbacks. The holiday test style defines a hover color. The README explains how to set date and hover backgrounds. The project version changes to 4.7.0-SNAPSHOT. |
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Feature · Severity of issue fixed: Medium
Suggested reviewers: javier-godoy
Merge Risk: 
fb8eb
-
The change provides the requested customizable hover background without changing existing default behavior.
Pre-merge checks: 
-
Check name Status Explanation Resolution Out of Scope Changes check The pom.xmlchanges the project version from4.6.3-SNAPSHOTto4.7.0-SNAPSHOT. The linked issues and the current PR intent require the hover custom property and its documentation. They do not re…Remove the unrelated pom.xmlversion change, or provide a separate release/versioning requirement that makes this change part of the PR scope.-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title says the PR adds the ability to customize the hover background of dates. The raw summary shows the README 'Styling dates' section, the --hover-background-color fallback in vaadin-month-calen… Linked Issues check The CSS rule uses var(--hover-background-color, var(--lumo-primary-color-10pct, var(--aura-background-color))). This adds the requested custom property and preserves both theme fallbacks from#124. …Full details: Title check
-
Explanation
The title says the PR adds the ability to customize the hover background of dates. The raw summary shows the README 'Styling dates' section, the --hover-background-color fallback in vaadin-month-calendar.css, and a test holiday hover rule, and the objectives describe a --hover-background-color CSS custom property for date hover backgrounds. The title names the main change, so the check passes.
Full details: Linked Issues check
-
Explanation
The CSS rule uses
var(--hover-background-color, var(--lumo-primary-color-10pct, var(--aura-background-color))). This adds the requested custom property and preserves both theme fallbacks from#124. The property can be set on a date class without copying the high-specificity hover selector. The README documentsthemeFor,--background-color, and--hover-background-colorwith a.holidayexample, which satisfies#4. The changed holiday styling fixture provides coverage for the custom hover value.
-
Full details: Out of Scope Changes check
-
Explanation
The
pom.xmlchanges the project version from4.6.3-SNAPSHOTto4.7.0-SNAPSHOT. The linked issues and the current PR intent require the hover custom property and its documentation. They do not require a project version change. The README, CSS change, and holiday styling fixture are connected to the linked issues.Resolution
Remove the unrelated
pom.xmlversion change, or provide a separate release/versioning requirement that makes this change part of the PR scope.
-
Finishing Touches
-
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
|
Add a
--hover-background-colorcustom property so the hover background of a date can be styled, falling back to the current theme defaults. The demo uses it for holidays, and the README documents how to style dates.Close #124
Close #4
Summary by CodeRabbit
--hover-background-color, while existing theme defaults remain available as fallbacks.