Skip to content

fix(demo): configure resourceBases for Jetty 11 - #214

Merged
javier-godoy merged 1 commit into
masterfrom
fix-213
Oct 27, 2026
Merged

javier-godoy merged 1 commit into
masterfrom
fix-213

Conversation

@paodb

@paodb paodb commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

The jetty-maven-plugin configuration declared resourceBases inside <webAppConfig>, the Jetty 9 parameter name, which Jetty 11 ignores. As a result the demo did not serve src/test/resources/META-INF/resources and demo-styles.css was not loaded. All profiles use Jetty 11, so the parameter is renamed to <webApp>.

Close #213

Summary by CodeRabbit

  • Configuration
    • Updated the Jetty Maven plugin configuration while preserving the existing test and main resource locations.

@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d024753d-3a60-475f-82c5-940eb54ebf89
📥 Commits

Reviewing files that changed from the base of the PR and between 690fde6 and c8b7627.

📒 Files selected for processing: 1
  • pom.xml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The Jetty Maven plugin now declares both existing META-INF/resources resource bases inside webApp instead of webAppConfig.

Changes

Jetty resource configuration

Layer / File(s) Summary
Update Jetty plugin configuration
pom.xml
The Jetty plugin configuration uses webApp for the existing test and main resource bases.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: javier-godoy

Merge Risk: ⚪ Minimal · up to c8b76

The demo resource configuration matches the stated Jetty 11 setup, with no merge-blocking risk identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: configuring resourceBases for Jetty 11 in the demo.
Linked Issues check Passed Issue [#213] requires Jetty 11 to serve both META-INF/resources directories for the local demo. In pom.xml, the PR moves resourceBases from webAppConfig to webApp and retains src/test/resources/META-I…
Out of Scope Changes check Passed The diff changes only the Jetty Maven plugin configuration in pom.xml. It renames the Jetty configuration element required by issue [#213] and retains the existing resource bases. No unrelated source,…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Linked Issues check

Explanation

Issue [#213] requires Jetty 11 to serve both META-INF/resources directories for the local demo. In pom.xml, the PR moves resourceBases from webAppConfig to webApp and retains src/test/resources/META-INF/resources and src/main/resources/META-INF/resources. This matches the required Jetty 11 parameter and resource paths. The configuration supports serving demo-styles.css as a CSS resource.

Full details: Out of Scope Changes check

Explanation

The diff changes only the Jetty Maven plugin configuration in pom.xml. It renames the Jetty configuration element required by issue [#213] and retains the existing resource bases. No unrelated source, build, or published add-on changes are present.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@paodb
paodb marked this pull request as ready for review October 20, 2026 21:04
@javier-godoy
javier-godoy merged commit 05fb316 into master Oct 27, 2026
7 checks passed
@javier-godoy
javier-godoy deleted the fix-213 branch October 27, 2026 11:57
@github-project-automation github-project-automation Bot moved this from To Do to Pending release in Flowing Code Addons Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending release

Development

Successfully merging this pull request may close these issues.

Demo resources under META-INF/resources are not served with Jetty 11

2 participants