You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(demo): configure resourceBases for Jetty 11 - #214
The jetty-maven-plugin configuration declared resourceBases inside <webAppConfig>, the Jetty 9 parameter name, which Jetty 11 ignores. As a result the demo did not serve src/test/resources/META-INF/resources and demo-styles.css was not loaded. All profiles use Jetty 11, so the parameter is renamed to <webApp>.
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: d024753d-3a60-475f-82c5-940eb54ebf89
📥 Commits
Reviewing files that changed from the base of the PR and between 690fde6 and c8b7627.
📒 Files selected for processing: 1
pom.xml
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
Walkthrough
The Jetty Maven plugin now declares both existing META-INF/resources resource bases inside webApp instead of webAppConfig.
Changes
Jetty resource configuration
Layer / File(s)
Summary
Update Jetty plugin configuration pom.xml
The Jetty plugin configuration uses webApp for the existing test and main resource bases.
The demo resource configuration matches the stated Jetty 11 setup, with no merge-blocking risk identified.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the main change: configuring resourceBases for Jetty 11 in the demo.
Linked Issues check
Issue [#213] requires Jetty 11 to serve both META-INF/resources directories for the local demo. In pom.xml, the PR moves resourceBases from webAppConfig to webApp and retains src/test/resources/META-I…
Out of Scope Changes check
The diff changes only the Jetty Maven plugin configuration in pom.xml. It renames the Jetty configuration element required by issue [#213] and retains the existing resource bases. No unrelated source,…
Docstring Coverage
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Linked Issues check
Explanation
Issue [#213] requires Jetty 11 to serve both META-INF/resources directories for the local demo. In pom.xml, the PR moves resourceBases from webAppConfig to webApp and retains src/test/resources/META-INF/resources and src/main/resources/META-INF/resources. This matches the required Jetty 11 parameter and resource paths. The configuration supports serving demo-styles.css as a CSS resource.
Full details: Out of Scope Changes check
Explanation
The diff changes only the Jetty Maven plugin configuration in pom.xml. It renames the Jetty configuration element required by issue [#213] and retains the existing resource bases. No unrelated source, build, or published add-on changes are present.
Full details: Docstring Coverage
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The jetty-maven-plugin configuration declared
resourceBasesinside<webAppConfig>, the Jetty 9 parameter name, which Jetty 11 ignores. As a result the demo did not servesrc/test/resources/META-INF/resourcesanddemo-styles.csswas not loaded. All profiles use Jetty 11, so the parameter is renamed to<webApp>.Close #213
Summary by CodeRabbit