You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: keep overflow badge height with Aura theme - #54
With the Aura theme the overflow badge inherited line-height: 0 from the context menu and collapsed to 2px. Use display: flex on the context menu instead, which keeps the alignment fixed in #38 without overriding the badge line height.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
Walkthrough
The vaadin-context-menu rule now uses display: flex instead of line-height: 0.
Changes
Overflow badge layout
Layer / File(s)
Summary
Context menu layout src/main/resources/META-INF/resources/frontend/src/fc-badge-list.ts
The vaadin-context-menu rule replaces line-height: 0 with display: flex.
The change targets the reported Aura overflow-badge height issue, and the available source shows no concrete layout regression. The PR appears mergeable with normal checks.
Pre-merge checks: 5
Passed checks: 5 passed
Check name
Status
Explanation
Linked Issues check
Issue #53 requires the Aura overflow badge to remain visible at the correct height. The PR changes vaadin-context-menu in fc-badge-list.ts to display: flex and removes the line-height: 0 decla…
Out of Scope Changes check
The reviewed change is limited to the vaadin-context-menu layout declaration in fc-badge-list.ts. This change directly supports issue #53 and the PR intent. The repository summary reports no other…
Docstring Coverage
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly describes the main change: preserving overflow badge height with the Aura theme.
✨ Finishing Touches
📝 Generate docstrings
Commit to this branch
Create a new PR
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the Aura theme the overflow badge inherited
line-height: 0from the context menu and collapsed to 2px. Usedisplay: flexon the context menu instead, which keeps the alignment fixed in #38 without overriding the badge line height.Close #53
Summary by CodeRabbit