Skip to content

fix: keep overflow badge height with Aura theme - #54

Merged
javier-godoy merged 1 commit into
masterfrom
issue-53
Oct 14, 2026
Merged

javier-godoy merged 1 commit into
masterfrom
issue-53

Conversation

@paodb

@paodb paodb commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

With the Aura theme the overflow badge inherited line-height: 0 from the context menu and collapsed to 2px. Use display: flex on the context menu instead, which keeps the alignment fixed in #38 without overriding the badge line height.

Close #53

Summary by CodeRabbit

  • Style
    • Updated context menu layout to use flex display and removed the zero line-height setting.

@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a7c7b5f5-0fd9-45ed-a94d-a4c2f0bb4758
📥 Commits

Reviewing files that changed from the base of the PR and between 75a7be7 and 39fa5bd.

📒 Files selected for processing: 1
  • src/main/resources/META-INF/resources/frontend/src/fc-badge-list.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The vaadin-context-menu rule now uses display: flex instead of line-height: 0.

Changes

Overflow badge layout

Layer / File(s) Summary
Context menu layout
src/main/resources/META-INF/resources/frontend/src/fc-badge-list.ts
The vaadin-context-menu rule replaces line-height: 0 with display: flex.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to 39fa5

The change targets the reported Aura overflow-badge height issue, and the available source shows no concrete layout regression. The PR appears mergeable with normal checks.

Pre-merge checks: Passed 5
Passed Passed checks: 5 passed
Check name Status Explanation
Linked Issues check Passed Issue #53 requires the Aura overflow badge to remain visible at the correct height. The PR changes vaadin-context-menu in fc-badge-list.ts to display: flex and removes the line-height: 0 decla…
Out of Scope Changes check Passed The reviewed change is limited to the vaadin-context-menu layout declaration in fc-badge-list.ts. This change directly supports issue #53 and the PR intent. The repository summary reports no other…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main change: preserving overflow badge height with the Aura theme.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@paodb
paodb marked this pull request as ready for review October 14, 2026 14:43
@javier-godoy
javier-godoy merged commit a1d6118 into master Oct 14, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from To Do to Pending release in Flowing Code Addons Oct 14, 2026
@javier-godoy javier-godoy moved this from Pending release to Done in Flowing Code Addons Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Overflow badge collapses to 2px height with Aura theme

2 participants