Repository navigation
fix: Libre.fm sign-in, Auto above 1080p, resume after a decoder failure, and a progress bar setting - #1663
Merged
Conversation
…not low on memory
…ontrols are hidden
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
authTokenform ofauth.getMobileSession(MD5 of the lower-cased user name and the password's MD5), which is the only form GNU FM accepts. Last.fm keeps the password form.Related issue
Closes #1658
Closes #1617
Closes #1550
Closes #1527
Change type
Validation
./gradlew :app:assembleGithubDebug(passed)./gradlew :app:testGithubDebugUnitTest(4,883 tests, 0 failures; newPlayerErrorHandlerDecoderTest, extendedAudioscrobblerClientTest,ClearedMediaRecoveryStateTestandAdaptiveTrackSelectorDefaultsTest)ktlintCheck,:app:compileFossDebugKotlin, nightly notes check passed)Test device and Android version: Resizable emulator, Android 17 (API 37)
Screenshots or recordings
Risk and compatibility
Player path: the track selector's device cap and the decoder give-up path. Phones that are not low-RAM can now pick 1440p or 4K in Auto when the screen is large enough. Playback memory stays bounded by the buffer byte targets.
New device-scoped preference
portrait_idle_progress_bar, default On video. No Room change.The change does not introduce secrets, private data, or unexpected telemetry.
New user-facing text uses Android string resources.
Dependency and lockfile changes are intentional and limited to this PR.
Room schema changes include the required version bump and migration, or this PR does not change the Room schema.
Breaking changes and upgrade steps are clearly documented.