Repository navigation
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 7.4 of FLOW-SYNC/2: linked devices become the default way to sync. On the Sync devices page's first step, the Linked devices section now comes first. The FLOW-SYNC/1 send and receive cards move below a divider, under a "One-time transfer" heading. The send and receive steps themselves don't change.
Copy: where the meaning changed, this PR adds new keys so other locales don't keep the old wording (only
values/strings.xmlis touched; the old keys are removed there):sync_devices_subtitle("...over local Wi-Fi") is replaced bysync_devices_summary.linked_introis replaced bylinked_always_intro(always in sync, end-to-end encrypted).sync_introis replaced bysync_one_time_titleandsync_one_time_body.sync_devices_titleandlinked_titlekeep their text. Nightly note added.Merge only after the owner's security audit (owner's decision).
Related issue
None.
Change type
Validation
./gradlew :app:assembleGithubDebug: not run separately; the unit test task below compiled the github debug sources../gradlew --offline -Dorg.gradle.jvmargs="..." :app:testGithubDebugUnitTest --tests 'io.github.aedev.flow.sync2.*' --tests 'io.github.aedev.flow.ui.screens.sync.*' --tests 'io.github.aedev.flow.ui.screens.settings.*': 281 tests, 0 failures.--tests 'io.github.aedev.flow.TranslationFormatStringsTest': passed../gradlew --offline ... ktlintCheck: exit 0.python3 .github/scripts/nightly_notes.py --check: 75 nightly notes are valid.Test device and Android version: none yet.
Risk and compatibility
UI order and copy only; no sync behaviour, storage or permission change. Removing three English keys leaves their translations orphaned until Weblate drops them.