[A-EDev]

Summary

Session.read, bootstrap, heldPaths and GroupStore.download looped until a page came back empty, so a store answering the same page forever kept sync running forever. They now stop when a page doesn't advance the cursor or any position (next <= cursor for cursor reads), as Flow Desktop does (Flow-Tube/Flow-Desktop#389). FileLayout.pullLogs stops at a file whose header doesn't name the sender and seq it was fetched for (for example a 200 error page served for every path), through a new namesLogObject.

Related issue

Change type

• Bug fix
• Feature
• Refactor or maintenance
• Build, packaging, or CI
• Documentation

Validation

• ./gradlew :app:assembleGithubDebug: not run on this branch; CI builds the APK
• ./gradlew --offline :app:testGithubDebugUnitTest --tests 'io.github.aedev.flow.sync2.*' --tests 'io.github.aedev.flow.sync.*': 161 sync2 and 162 sync tests, 0 failures. Shared StuckPages stub; new tests in SessionTest, GarbageCollectionTest, HeldStoreTest, FileLayoutTest; before, all four failed with IllegalStateException: the same page was read forever
• ./gradlew --offline ktlintCheck: passed
• I manually tested the affected behavior on an Android device or emulator.

Test device and Android version: not device-tested yet

Risk and compatibility

Valid stores always advance, so normal syncs are unchanged.

• The change does not introduce secrets, private data, or unexpected telemetry.
• New user-facing text uses Android string resources.
• Dependency and lockfile changes are intentional and limited to this PR.
• Room schema changes include the required version bump and migration, or this PR does not change the Room schema.
• Breaking changes and upgrade steps are clearly documented.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.