Skip to content

test(sync2): update the shared vectors to flow-sync 4c8c176 and refuse seq above 2^53 - #1650

Merged
1 commit merged into
mainfrom
test/sync2-vectors
Nov 2, 2026
Merged

1 commit merged into
mainfrom
test/sync2-vectors

Conversation

@A-EDev

@A-EDev A-EDev commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

Refreshes the vendored FLOW-SYNC/2 vectors to Flow-Tube/flow-sync 4c8c176 and follows the new envelope rule: parseObject refuses a seq outside 0..2^53-1 with the new ProtocolError.RANGE (range), right after the group check (flow-sync #67). All 11 files copied unchanged; only canonical, envelope and recovery differed (Kotlin's String order already gives the RFC 8785 key order of flow-sync #70, and 24-word recovery was already enforced). The README named cab3979, but the files matched b6b0609 byte for byte, so only the README was stale; it now names 4c8c176.

Related issue

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Build, packaging, or CI
  • Documentation

Validation

  • ./gradlew :app:assembleGithubDebug: not run on this branch; CI builds the APK
  • ./gradlew --offline :app:testGithubDebugUnitTest --tests 'io.github.aedev.flow.sync2.*' --tests 'io.github.aedev.flow.sync.*': 157 sync2 and 162 sync tests, 0 failures. Before: VectorsTest.envelopes_open_in_stream_order failed with expected:<[range]> but was:<[gap]>; after: VectorsTest 11/11
  • ./gradlew --offline ktlintCheck: passed
  • I manually tested the affected behavior on an Android device or emulator.

Test device and Android version: not device-tested yet

Risk and compatibility

Protocol conformance only.

  • The change does not introduce secrets, private data, or unexpected telemetry.
  • New user-facing text uses Android string resources.
  • Dependency and lockfile changes are intentional and limited to this PR.
  • Room schema changes include the required version bump and migration, or this PR does not change the Room schema.
  • Breaking changes and upgrade steps are clearly documented.

Copilot AI balanced review requested due to automatic review settings November 2, 2026 16:12

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Nov 2, 2026
@A-EDev A-EDev closed this pull request by merging all changes into main in 9f6bf1c Nov 2, 2026
@A-EDev
A-EDev deleted the test/sync2-vectors branch November 2, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants