Repository navigation
fix: artist picker, notification artwork, sync crash, Metrolist artists, search on Android 8 and dub downloads - #1649
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This was referenced Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hqdefaultas the fallback for a missing large YouTube thumbnail. Media3 only loads a song's artwork once, so one failed fetch used to leave the whole song without art. The size cap for [Bug]: cannot use a recycled source in createBitmap #1017/[Bug]: IllegalArgumentException in Bitmap.java:942 #1231 is unchanged. ([Bug]: Album artwork fails to load in the Android notification player during extended background playback #1637)SyncForegroundGate), and a new session waits for a cancelled one's cleanup. A sync that failed its first dial at once crashed with "did not then call startForeground". ([Bug]: RemoteServiceException in ActivityThread.java:2280 #1639)song_artist_mapandartist, saving every song's artists in credit order with the first artist's channel. Rows are written withmergeMetadata, so importing the same backup again fixes playlists already imported. The importer moved out ofBackupRepositoryintoMetrolistImporter. ([Bug]: Importing a playlist from Metrolist doesn't show the artist names #1619)PackageInfoCompat, so crash reports, Diagnostics and About work on Android 8. ([Bug]: Search option stucks #1635).gitignore:metro*only applies at the repo root, so it no longer hidesMetrolistImporter.kt.Related issue
Closes #1637
Closes #1639
Closes #1638
Closes #1635
Closes #1619
Closes #1634
Change type
Validation
./gradlew :app:assembleGithubDebug: builds../gradlew :app:testGithubDebugUnitTest: 4770 tests, 0 failures, 2 skipped. New:SyncForegroundGateTest,MetrolistCreditsTest,SearchSongArtistsTest,SessionArtworkRetryTest,SabrAudioTrackPickTest,PlaylistCardCountTest, the load dispatcher case inSearchPagingSourceTestand the dub case inTransferStateTest.ktlintCheckand:app:compileFossDebugKotlinpass.Test device and Android version: POCO X6 Pro, HyperOS (Android 16)
Screenshots or recordings
Risk and compatibility
No Room schema change.
TransferStategains an optionaltrackId; old state files still read, and a paused download of a dubbed video starts its audio over once.Session artwork bypasses Coil's memory cache so a ROM that recycles session bitmaps ([Bug]: cannot use a recycled source in createBitmap #1017) never touches one the UI holds.
The sync service may briefly show its notification when a sync fails within milliseconds.
The change does not introduce secrets, private data, or unexpected telemetry.
New user-facing text uses Android string resources.
Dependency and lockfile changes are intentional and limited to this PR.
Room schema changes include the required version bump and migration, or this PR does not change the Room schema.
Breaking changes and upgrade steps are clearly documented.