Skip to content

fix: artist picker, notification artwork, sync crash, Metrolist artists, search on Android 8 and dub downloads - #1649

Merged
A-EDev merged 15 commits into
mainfrom
fix/artists-artwork-sync-search-imports
Nov 2, 2026
Merged

A-EDev merged 15 commits into
mainfrom
fix/artists-artwork-sync-search-imports

Conversation

@A-EDev

@A-EDev A-EDev commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

Related issue

Closes #1637
Closes #1639
Closes #1638
Closes #1635
Closes #1619
Closes #1634

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Build, packaging, or CI
  • Documentation

Validation

  • ./gradlew :app:assembleGithubDebug: builds.
  • ./gradlew :app:testGithubDebugUnitTest: 4770 tests, 0 failures, 2 skipped. New: SyncForegroundGateTest, MetrolistCreditsTest, SearchSongArtistsTest, SessionArtworkRetryTest, SabrAudioTrackPickTest, PlaylistCardCountTest, the load dispatcher case in SearchPagingSourceTest and the dub case in TransferStateTest.
  • I ran any additional flavor-specific build or test tasks affected by this change: ktlintCheck and :app:compileFossDebugKotlin pass.
  • I manually tested the affected behavior on an Android device or emulator.
    • Straight Up (search) and Ashke (artist Popular) open the Artists sheet, and Mxrci opens Mxrci's page.
    • The [Bug]: Importing a playlist from Metrolist doesn't show the artist names #1619 sample imports with every artist.
    • Joining a code for a closed port shows "Couldn't reach the other device" with no crash.
    • Skipping tracks offline keeps the right notification art.
    • Search loads, and Mixes show no count while playlists keep theirs.

Test device and Android version: POCO X6 Pro, HyperOS (Android 16)

Screenshots or recordings

Risk and compatibility

  • No Room schema change. TransferState gains an optional trackId; old state files still read, and a paused download of a dubbed video starts its audio over once.

  • Session artwork bypasses Coil's memory cache so a ROM that recycles session bitmaps ([Bug]: cannot use a recycled source in createBitmap #1017) never touches one the UI holds.

  • The sync service may briefly show its notification when a sync fails within milliseconds.

  • The change does not introduce secrets, private data, or unexpected telemetry.

  • New user-facing text uses Android string resources.

  • Dependency and lockfile changes are intentional and limited to this PR.

  • Room schema changes include the required version bump and migration, or this PR does not change the Room schema.

  • Breaking changes and upgrade steps are clearly documented.

Copilot AI balanced review requested due to automatic review settings November 2, 2026 15:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@github-actions github-actions Bot added documentation Improvements or additions to documentation player Video and audio playback ui Compose UI, theming, or Material 3 surfaces sync Device-to-device sync labels Nov 2, 2026
@A-EDev
A-EDev merged commit 5079703 into main Nov 2, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation player Video and audio playback sync Device-to-device sync ui Compose UI, theming, or Material 3 surfaces

Projects

None yet

2 participants