Repository navigation
fix(sync2): visit only held objects when collecting a log - #1647
Merged
1 commit merged intoNov 2, 2026
Merged
1 commit merged into
1 commit merged into
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
collectGarbagelooped over everyseqin a range taken from other devices' acks and snapshot manifests, so a member-supplied range near 2^63 kept the worker spinning (a test ran at 106% CPU for over 3 minutes atGarbageCollection.kt:151, ignoring the JUnit timeout). It now visits only the objects this device holds in that range, and records progress exactly when the delete budget runs out.Related issue
Change type
Validation
./gradlew :app:assembleGithubDebug: not run locally, no app code outside sync2 changed; CI builds the APK./gradlew --offline :app:testGithubDebugUnitTest --tests 'io.github.aedev.flow.sync2.*' --tests 'io.github.aedev.flow.sync.*': 158 sync2 and 162 sync tests, 0 failures. The newGarbageCollectionTestcase finishes at once (before: spun until killed)./gradlew --offline ktlintCheck: passedTest device and Android version: not device-tested
Risk and compatibility
Deletes the same objects as before for normal ranges.