Repository navigation
fix(sync2): drop live messages beyond the queue limit and keep this device's within it - #1644
Merged
1 commit merged intoNov 2, 2026
Merged
1 commit merged into
1 commit merged into
Conversation
…evice's within it
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Incoming live
nowandplaymessages are dropped byopenLivewhen their queue holds more than 50 items, theirindexis outside the queue, orvolis outside 0..100, as spec/live.md says and Flow Desktop already does. While fixing it:NowPlayingsentqueue.take(50)with the real index, so itsnowwas invalid from the 51st item on and Flow Desktop dropped it; it now sends the 50-item window around the index.Related issue
Change type
Validation
./gradlew :app:assembleGithubDebug: not run locally, no app code outside sync2 changed; CI builds the APK./gradlew --offline :app:testGithubDebugUnitTest --tests 'io.github.aedev.flow.sync2.*' --tests 'io.github.aedev.flow.sync.*': 158 sync2 and 162 sync tests, 0 failures.LiveChannelTest3/3; before the fixopenLiveaccepted aplaywith 51 videos (expected null, but was LiveReceived)./gradlew --offline ktlintCheck: passedTest device and Android version: not device-tested
Risk and compatibility
Nightly note added.
cmdqueues over 50 (sent byRemoteDriver.setQueueandEnhancedMusicPlayerManager.queueEdited) are unchanged; the spec sets no limit for them, while Flow Desktop refuses more than 50.