Skip to content

fix(sync2): drop live messages beyond the queue limit and keep this device's within it - #1644

Merged
1 commit merged into
mainfrom
fix/sync2-live-queue
Nov 2, 2026
Merged

1 commit merged into
mainfrom
fix/sync2-live-queue

Conversation

@A-EDev

@A-EDev A-EDev commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

Incoming live now and play messages are dropped by openLive when their queue holds more than 50 items, their index is outside the queue, or vol is outside 0..100, as spec/live.md says and Flow Desktop already does. While fixing it: NowPlaying sent queue.take(50) with the real index, so its now was invalid from the 51st item on and Flow Desktop dropped it; it now sends the 50-item window around the index.

Related issue

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Build, packaging, or CI
  • Documentation

Validation

  • ./gradlew :app:assembleGithubDebug: not run locally, no app code outside sync2 changed; CI builds the APK
  • ./gradlew --offline :app:testGithubDebugUnitTest --tests 'io.github.aedev.flow.sync2.*' --tests 'io.github.aedev.flow.sync.*': 158 sync2 and 162 sync tests, 0 failures. LiveChannelTest 3/3; before the fix openLive accepted a play with 51 videos (expected null, but was LiveReceived)
  • ./gradlew --offline ktlintCheck: passed
  • I manually tested the affected behavior on an Android device or emulator.

Test device and Android version: not device-tested

Risk and compatibility

Nightly note added. cmd queues over 50 (sent by RemoteDriver.setQueue and EnhancedMusicPlayerManager.queueEdited) are unchanged; the spec sets no limit for them, while Flow Desktop refuses more than 50.

  • The change does not introduce secrets, private data, or unexpected telemetry.
  • New user-facing text uses Android string resources.
  • Dependency and lockfile changes are intentional and limited to this PR.
  • Room schema changes include the required version bump and migration, or this PR does not change the Room schema.
  • Breaking changes and upgrade steps are clearly documented.

Copilot AI balanced review requested due to automatic review settings November 2, 2026 13:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Nov 2, 2026
@A-EDev A-EDev closed this pull request by merging all changes into main in 9f6bf1c Nov 2, 2026
@A-EDev
A-EDev deleted the fix/sync2-live-queue branch November 2, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants