Repository navigation
feat(profiles): choose which profiles sync and link them - #1632
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
profilesrecord); its data stays everywhere. One profile here keeps syncing; a deletion from another device is honored even for the last one, and the device then adds no new device until a profile is linked again.profilescollection names each link: canonical{"deleted","hlc","link","name"}records, merged last-writer-wins, with a blank name for a default profile never renamed (shown as Default; a link with no record shows as an unnamed profile). A rename on another device renames the profile here. Each device snapshotsprofiles, and garbage collection waits for that snapshot.Related issue
Closes #1039
Change type
Validation
All Gradle runs used
--offline -Dorg.gradle.jvmargs="-Xmx4096m -XX:MaxMetaspaceSize=1024m -Dfile.encoding=UTF-8 -Djava.net.preferIPv6Addresses=true"../gradlew :app:assembleGithubDebug: builds../gradlew :app:testGithubDebugUnitTest: 4743 tests, 0 failures, 46 skipped. New:LinkedProfilesTest(linking, catching up only links already read, names and blank default names, last-writer-wins renames and deletions, the last profile staying linked, a deleted only link, the welcome link, profiles that are gone, adding a profile for a synced link) and theprofileswire test inProfileLinksTest.testFossDebugUnitTest4700 tests, 0 failures, 46 skipped;ktlintCheck,spotlessCheckandlintGithubReleasepass;assembleFossReleasebuilds, FOSS arm64-v8a APK 21,827,008 B (budget 29,500,000 B);nightly_notes.py --checkpasses.Test device and Android version:
Screenshots or recordings
Risk and compatibility
No schema change beyond the previous PR.
sync_default_only_bodyis removed with its translations, as nothing shows it any more. Theprofilesrecords match Flow Desktop byte for byte (flow-sync spec "Profiles").Device testing fix (flow-sync #65): a new device now joins the link of Default instead of the running profile, and only the running profile can start syncing, so a profile that is not in use offers "Switch to sync".