Repository navigation
feat(sync): apply batches per profile - #373
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Session::read_linkreads a link from its snapshot for a profile that joins it later. The next run does this for every link insync2_reading.profilesrecord is deleted.nowandplayname the running profile's link.Related issue
Part of FLOW-SYNC/2 Phase 6 (Flow-Tube/Flow#1039).
Change type
Validation
pnpm test: 188 files, 1099 tests passedpnpm build: passedcargo fmt --manifest-path src-tauri/Cargo.toml --all -- --check: cleancargo clippy --manifest-path src-tauri/Cargo.toml --all-targets --all-features: no warnings in the changed codecargo test --manifest-path src-tauri/Cargo.toml --all-targets --all-features: 1110 passed, 0 failed, 9 ignoredNew tests in
tests/sync2_profiles.rs:Screenshots or recordings
Risk and compatibility
No migration (uses 0036).
Only Default can be linked until profiles choose links. In another profile, Default's batches are now kept instead of left unread, and they apply on the first sync after switching back to Default.
Battery and network: a run in a profile without a link exports nothing and pushes nothing.
No new secrets, private data, telemetry, or broad Tauri permissions were introduced.
User-facing documentation was updated where needed.
Dependency and lockfile changes are intentional and limited to this PR.
Breaking changes and upgrade steps are clearly documented.