Repository navigation
feat(sync): store profile links, kept batches and profile names - #372
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0036_sync2_profiles.sql(additive) adds the tables profiles need (spec/protocol.md, Profiles):sync2_profile_links: local profile to link.sync2_sent_links: the upload ledger per link, with the existingsync2_sentrows copied under the group's link.sync2_kept: batches for a linked profile that isn't running.sync2_profiles: the profiles collection.sync2_floorsandsync2_reading: reading a link from its snapshot.Related issue
Part of FLOW-SYNC/2 Phase 6 (Flow-Tube/Flow#1039).
Change type
Validation
pnpm test: 188 files, 1099 tests passedpnpm build: passedcargo fmt --manifest-path src-tauri/Cargo.toml --all -- --check: cleancargo clippy --manifest-path src-tauri/Cargo.toml --all-targets --all-features: no warnings in the changed codecargo test --manifest-path src-tauri/Cargo.toml --all-targets --all-features: 1106 passed, 0 failed, 9 ignoredNew test:
tests/sync2_link_storage.rs(migrating a linked group keeps what it sent under its link; a restored group without a link carries nothing over).Screenshots or recordings
Risk and compatibility
Database: migration 0036, additive only. Every profile database gets the tables; only Default's holds rows.
sync2_sentis no longer read (listed as DEAD in the store inventory) but is still cleared when a group is forgotten, for builds before this one.No new secrets, private data, telemetry, or broad Tauri permissions were introduced.
User-facing documentation was updated where needed.
Dependency and lockfile changes are intentional and limited to this PR.
Breaking changes and upgrade steps are clearly documented.