Repository navigation
Make client-side features free, no authentication required + chart price fix - #114
Merged
Merged
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 11
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two changes, both aimed at making the plugin usable without an account:
api.osrs.cloud); wiki API (prices.runescape.wiki) and locally computed features are untouched by auth....button no longer auto-entered the price into the prompt.Client-side features now free (no auth/premium checks)
SlotStateDrawer): colored borders + quick-look tooltips in the GE interface no longer check premiumSlotPanel): slot status coloring no longer checks premium; the magnifying-glass quick-look icon is always visibleOfferGraphChartOverlay): no premium check (data comes from the wiki timeseries API)WikiDataFetcherJob): with the panel closed, polling continues whenever slot enhancement is enabled (a plain user preference) instead of requiring premium; the premium-only 30s interval is removed — everyone uses the standard 60sAuth still required (unchanged) for own-API features
SlotSenderJob, gated bycanCommunicateWithApi)Cleanup
ApiAuthHandler.isPremium, premium subscriptions, and the resub panel inLoggedInPanelsetPremiumStatus()replaced bycheckApiSession(), which still validates the stored JWT against our API and drives the existing login-error/retry UXshouldEnhanceSlots()is now side-effect free (reads viaviewAccountWideData()) since the wiki job polls it every second — the old dirty-marking read would have caused constant autosavesUserDTO: dropped unusedisPremiumChart price fix
The price prompt moved to the long input mode (
MESLAYERMODE 30) in the 2026-09-30 game update and no longer reliably runs script 108 when opened via the...button, so the pending chart price was never entered. Additionally,render()could clear the pending price while the prompt was open because the GE frame state during the prompt is unreliable.VarClientIntChangedonMESLAYERMODE == 30, mirroring howGameUiChangesHandlerdetects prompts), with the script 108 path kept as a fallbackrender()no longer clears the pending price while a numeric prompt is openTesting
gradlew clean buildpasses, including newOfferGraphChartOverlayTestcovering: price prompt entering the pending price, quantity prompt not consuming it, unrelated varc changes being ignored, and the script 108 fallbackSummary by CodeRabbit
New Features
Bug Fixes
Documentation