Repository navigation
hub: include README in publish snapshots so the Plugin Hub page shows the description - #112
Conversation
runelite.net renders the plugin description by fetching repos/Flipping-Utilities/rl-plugin/readme?ref=<pinned commit> from the GitHub API. The current pin (a hub/publish snapshot) strips README.md, so https://runelite.net/plugin-hub/show/flipping-utilities shows no description. - publish-hub.sh: keep README.md in the snapshot alongside the packager inputs. The Hub build itself ignores it, but the pinned commit must carry it for the website. Dry run: the next snapshot on top of the current pin 2057976 adds only README.md (jar unchanged). - README.md: switch image URLs from github.com blob/... to raw.githubusercontent.com. The hub page leaves absolute URLs untouched and blob URLs serve HTML, so the old links rendered as broken images there; raw URLs render on both github.com and the hub. - publish-hub.yml: include the existing authors= pointer line in the summary so future pin PRs keep the descriptor intact.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
What & why
https://runelite.net/plugin-hub/show/flipping-utilitiesshows no description because the site fetches the README from the pinned commit (repos/Flipping-Utilities/rl-plugin/readme?ref=<pin>) andhub/publishsnapshots stripREADME.md. This addsREADME.mdto the publish snapshot so the next pin carries it, and fixes the README image URLs so they render on the hub page.Testing
No Java changes;
./gradlew clean buildnot affected (CI runs it).Dry run of the snapshot pipeline (Git Bash):
HUB_BRANCH=hub/readme-dryrun HUB_BASE=HEAD bash .github/scripts/publish-hub.shseeded from the live Hub pin2057976, reported "no plugin changes to snapshot" for the seed, and appended exactly one snapshot commit.git diff --stat 2057976 hub/readme-dryrun→README.md | 324 +++++— the only change; the packaged jar is unchanged.LICENSE README.md icon.png runelite-plugin.properties src.Image URL check:
curl https://raw.githubusercontent.com/Flipping-Utilities/rl-plugin/master/images/flipping.png→200 image/png(oldblob/URLs return HTML and render broken on the hub page, which does not rewrite absolute URLs).CI will additionally validate the new snapshot with the official Plugin Hub packager when it appends it to
hub/publish../gradlew clean buildgreenRisk
High tier (CI/publish script), low blast radius: the packager ignores
README.md(it is in plugin-hub-tooling'sCORE_SOURCE_TEST), and the pin-to-pin review diff is a single added file. No code, config, or persistence changes.How to revert
Revert this commit on
master; the Publish Plugin Hub branch workflow re-runs and the snapshot returns to the previous tree (README drops out of later snapshots;hub/publishhistory is untouched, append-only). No Plugin Hub re-pin is needed unless the README-bearing pin was already submitted.In-game verification
None — no in-game behavior.
Generated-by: GLM-5.3 (OpenCode)
Summary by CodeRabbit