Repository navigation
Write the inverted value through a negated Bool binding - #9
Merged
Merged
Conversation
The setter of `!binding` wrote the new value unchanged into the original binding, so toggling a control bound to `!$isOff` stored the opposite of what the user chose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
prefix func !onBinding<Bool>wrote the incoming value unchanged instead of inverting it.Toggle(isOn: !$isOff)therefore stored the opposite of what the user chose, and the toggle jumped back. The setter now writes!$0.Split out of #7.
How this was verified
BindingExtTests.negatedBindingWritesTheInvertedValuesets the negated binding tofalseandtrueand checks the stored value.Red, with
main'sBindingExt.swift:Green, this branch: