Repository navigation
Describe precisely what isPersisted checks - #22
Merged
Merged
Conversation
The documentation said the model "exists in the database", but the property only checks whether it was inserted into a ModelContext, which is true before the context is saved. It now says so and points to persistentModelID.isTemporary for the saved state.
The doc comment now says that isPersisted turns true on insert, before any save; a test with an in-memory container pins that. The example also called insert with try, which does not throw.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The docs of
PersistentModel.isPersistedsaid it tells whether a model "exists in the database". The property checksmodelContext != nil, which istrueright afterinsert(_:), before any save. The docs now say that and point topersistentModelID.isTemporary(iOS 27 and the other OS 27 versions) for the saved state. The example no longer callsinsertwithtry, which does not throw.Split out of #7.
How this was verified
New
PersistentModelExtTests.insertingIsEnoughWithoutSavingwith an in-memoryModelContainer:isPersistedisfalsebefore the insert andtrueafter it, while the context still has unsaved changes.No code change, so there is no red run; the test pins the documented behavior.