Repository navigation
Avoid the deprecated onChange(of:perform:) on visionOS - #21
Merged
Merged
Conversation
onChange(of:perform:) is deprecated starting with iOS 17 and from the start on visionOS, so LimitedTextField produced a deprecation warning there. An internal onValueChange helper picks the two-parameter variant where it exists and falls back to the old one below iOS 17. It is not public and goes away once the minimum reaches iOS 17.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
onChange(of:perform:)is deprecated from the start on visionOS (and starting with iOS 17 elsewhere), soLimitedTextFieldproduced a deprecation warning in every visionOS build of an app using the package. An internalonValueChange(of:perform:)helper uses the two-parameteronChangewhere it exists and falls back to the old one below iOS 17. It is not public and goes away once the minimum reaches iOS 17.CachedAsyncImagehas the same warning; its fix (.task(id:)) comes with theCachedAsyncImagePR.Split out of #7.
How this was verified
Generic visionOS build (
xcodebuild -scheme HandySwiftUI -destination 'generic/platform=visionOS'),onChangedeprecation warnings:The iOS build succeeds as well. Behavior is unchanged: both variants call the action with the new value.