Repository navigation
Respect muteContent in HorizontalLabeledContentStyle - #13
Merged
Merged
Conversation
The style always rendered the content in the secondary style, so `.horizontal(muteContent: false)` had no effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
HorizontalLabeledContentStyle(muteContent:)ignored its parameter and always rendered the content in.secondary. The content is now secondary only whenmuteContentistrue(the default), so nothing changes for callers that don't passfalse.Split out of #7. Adds the small
renderedPixels(of:)test helper, which compares two views rendered withImageRenderer.How this was verified
HorizontalLabeledContentStyleTestsrenders the style withmuteContent: trueandfalseand compares the pixels with a hand-built reference in.secondaryand.primary.Red, with
main's style:Green, this branch: