Repository navigation
Encode NSImage.jpegData as JPEG instead of JPEG 2000 - #12
Merged
Merged
Conversation
The method used the .jpeg2000 file type, so callers expecting a JPEG received a JPEG 2000 file that many consumers (browsers, upload APIs) cannot read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
NSImage.jpegData(compressionQuality:)encoded with.jpeg2000, so on macOS it returned JPEG 2000 data that many consumers (uploads,UIImage, web) cannot read, while the name promises JPEG likeUIImage.jpegData. It now encodes with.jpeg.Split out of #7.
How this was verified
ImageExtTests.jpegDataEncodesAsJPEGchecks the JPEG magic bytesFF D8 FF.Red, with
main'sImageExt.swift:Green, this branch: