Repository navigation
Strip symbol metadata in Image and Label convertible initializers - #11
Merged
Merged
Conversation
CustomSymbolConvertible allows metadata after `:` or `*` (rotation and repeat count used by HPicker and VPicker) and documents that it is ignored when creating images. Image(convertible:) and Label(convertible:) passed the raw name though, so such symbols showed no icon at all, also in the CaseIterable Picker initializer and SideTabView that build on them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Image(convertible:)andLabel(convertible:)passed the rawsymbolNametoImage(systemName:), including the:angle*countmetadata thatCustomSymbolConvertibledocuments as ignored (e.g."star:45*2"). That is not a valid symbol name, so no image showed. Both now usesymbolSystemName, asCustomLabelConvertible.labelalready did. This also fixes theCaseIterablePickerinitializer andSideTabView, which go through these initializers.Split out of #7.
How this was verified
ConvertibleTestsuses a type whosesymbolNameis"star:45*2"and expects the same image asImage(systemName: "star").Red, with
main's sources:Green, this branch: