Repository navigation
Avoid force-casting allCases in HPicker and VPicker - #10
Merged
Merged
Conversation
CaseIterable only requires AllCases to be a Collection, so a type with a non-Array AllCases crashed the CaseIterable initializers with a failed `as! [T]` cast. Array(T.allCases) works for every collection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The
CaseIterableinitializers ofHPickerandVPickerforce-castT.allCases as! [T], which crashes for types whoseAllCasesis not anArray(for example a customallCasesreturning aContiguousArray). They now useArray(T.allCases), which is identical for the usualArraycase.Split out of #7.
How this was verified
PickerTestsbuilds both pickers for an enum whoseAllCasesis aContiguousArray.Red, with
main'sHPicker.swift/VPicker.swift(the old code crashes the test process):Green, this branch:
No behavior change for apps: FocusBeats and CrossCraft use the pickers only with plain enums, whose
AllCasesis anArray.