Repository navigation
[rc-1.6.0] Installer: a rerun keeps the web backup of the release it upgraded from - #2004
Merged
Merged
Conversation
configureHttpd() names the web backup after the version being installed and removes any existing one first. A 1.5 -> 1.6 upgrade run twice therefore replaced the 1.5 tree with the 1.6 one, and revertfog.sh had no web tree left to restore. _setAsideOtherVersionWebBackup() reads the backup's own FOG_VERSION and, when it is another release, renames it after that release instead. A backup of the same release is still replaced. revertfog.sh finds the renamed one by its fog_web_*.BACKUP glob. The release notes said both backups are named after the version upgraded from, and that revertfog.sh runs from a 1.5 checkout. Neither was true: they carry the installed version, and the script exists only on 1.6. Refs #2000 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #2003 to
rc-1.6.0. The cherry-pick applied cleanly, andtests/web-backup-keeps-other-release.test.shpasses 9 of 9 on this branch.Refs #2000
🤖 Generated with Claude Code