Repository navigation
Add the Performance Test task type (fos#55) [rc-1.6.0] - #1982
Merged
Merged
Conversation
FOS can now boot with mode=perftest. It times the disk, the network and decompression on the client, then reports the result before it completes the task. The task changes nothing on the disk. Schema step 444 adds task type 27 and the hostPerfTests table. The rows go with the host (CASCADE, group 14). The task id is an audit column with no constraint, like taskLog.taskID. service/perftest.php takes the report. It has no credential, so it refuses unless the host has a Performance Test task in flight. It also checks every field and names the bad one in the refusal. FOS treats the body `##` as success. The rules are in HostPerfTest::refusal() so a test can drive them without a database. The host page has a read-only Performance tab under History Items. It lists the runs newest first. A rate of 0 shows as "not measured". A ratio of 250 shows as 2.50:1. The new tests/perftest-report.test.php covers the refusals and the formatting. Three existing tests pinned numbers that this step moves: the foreign-key counts in two docs, the rehearsal baseline, and the "step 443 is the last step" check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server half of FOGProject/fos#55. The FOS half is FOGProject/fos#198, which merges after this.
Adds the Performance Test advanced task type. FOS boots with
mode=perftest, times the disk, the network and decompression, and posts the result. The host page keeps every run.mode=perftest, advanced, host and group), and tablehostPerfTests(one row per run, FK to hosts with CASCADE). FOG_SCHEMA is now 444.service/perftest.php: refuses an unknown host, a host with no active Performance Test task, and any invalid field. It saves one row and answers##. The rules live inHostPerfTest::refusal()/validate(), so the tests run them without a DB.tests/perftest-report.test.php, 46 checks. Proven red: dropping the task-type check fails 4, and dropping the format whitelist fails 2. Tests that pinned the old schema numbers were updated.tests/run-all.sh: 412 passed, 0 failed. Both phpstan passes are clean, unscoped. The new_()strings are not inmessages.potyet; the CI regen job adds them.🤖 Generated with Claude Code