mesh: fix transfer_meshtags_to_submesh sentinel collision, close test gaps - #4524
Merged
jhale merged 6 commits intoSep 18, 2026
Merged
Conversation
jhale
added this pull request to stack #4520
September 15, 2026 10:19
jorgensd
reviewed
Sep 15, 2026
jorgensd
reviewed
Sep 15, 2026
jorgensd
reviewed
Sep 15, 2026
jorgensd
reviewed
Sep 15, 2026
jhale
force-pushed
the
jhale/mesh-review-wp7-test-gaps
branch
from
September 15, 2026 13:03
bac896b to
0093042
Compare
jhale
marked this pull request as ready for review
September 15, 2026 13:05
jhale
force-pushed
the
jhale/mesh-review-wp7-test-gaps
branch
from
September 15, 2026 13:12
0093042 to
558c6af
Compare
jhale
force-pushed
the
jhale/mesh-review-wp7-test-gaps
branch
from
September 15, 2026 13:50
dd66665 to
b24d553
Compare
jhale
force-pushed
the
jhale/mesh-review-wp7-test-gaps
branch
from
September 15, 2026 13:59
c5f0e16 to
95b06ed
Compare
jhale
force-pushed
the
jhale/mesh-review-wp7-test-gaps
branch
from
September 15, 2026 14:22
95b06ed to
a8f1e6d
Compare
jhale
force-pushed
the
jhale/mesh-review-wp7-test-gaps
branch
from
September 15, 2026 18:42
a8f1e6d to
40e3085
Compare
jhale
force-pushed
the
jhale/mesh-review-wp7-test-gaps
branch
from
September 16, 2026 08:16
40e3085 to
4841df7
Compare
chrisrichardson
approved these changes
Sep 16, 2026
jhale
force-pushed
the
jhale/mesh-review-wp7-test-gaps
branch
from
September 16, 2026 15:19
4841df7 to
74bc544
Compare
garth-wells
approved these changes
Sep 17, 2026
jhale
force-pushed
the
jhale/mesh-review-wp7-test-gaps
branch
from
September 17, 2026 06:27
74bc544 to
218574d
Compare
jhale
force-pushed
the
jhale/mesh-review-wp7-test-gaps
branch
2 times, most recently
from
September 17, 2026 16:39
8a8f6ba to
d254c5d
Compare
jhale
force-pushed
the
jhale/mesh-review-wp7-test-gaps
branch
from
September 18, 2026 07:51
d254c5d to
4b4a5dd
Compare
… gaps Replaces the numeric_limits<T>::max() "unmapped" sentinel in transfer_meshtags_to_submesh with an explicit found-flag vector: a legitimate tag value equal to that sentinel was being silently dropped from the transferred result. Adds regression tests for two previously-untested paths: create_submesh with zero selected entities on some ranks (previously only traced by hand, never executed), and the sentinel-collision fix above. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Updated docstrings for degenerate rectangle and box tests to clarify error handling across ranks.
Update the test description for clarity.
Removed a regression test for transferring mesh tags that checks if the maximum integer value survives the transfer process. There is no chance that this will be regressed.
This reverts commit 47ace3d.
jhale
force-pushed
the
jhale/mesh-review-wp7-test-gaps
branch
from
September 18, 2026 09:40
4b4a5dd to
c2e3f22
Compare
An error occurred while trying to automatically change base from
jhale/mesh-review-wp5-docs
to
jhale/mesh-review-wp4-exception-types
September 18, 2026 11:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the numeric_limits::max() "unmapped" sentinel in
transfer_meshtags_to_submesh with an explicit found-flag vector: a
legitimate tag value equal to that sentinel was being silently dropped
from the transferred result.
Adds regression tests for three previously-untested paths: a
cells/celltypes length mismatch across ranks in build_dual_graph (the
same MPI-ordering defect class as WP1, now verified not to hang),
create_submesh with zero selected entities on some ranks (previously
only traced by hand, never executed), and the sentinel-collision fix
above.
Left cpp/test/mesh/generation.cpp's commented-out per-row adjacency
checks disabled: re-enabling them exposes a real discrepancy between
build_tet's cell-vertex order and the hand-written expected tables,
but Topology construction reorders cell vertices during distribution
and no ordering contract is documented for connectivity(tdim, 0), so
it's unclear whether this is a build_tet bug or an outdated fixture.
Left as a follow-up rather than guessing.
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Stack created with GitHub Stacks CLI • Give Feedback 💬