mesh: reorder transfer_meshtags_to_submesh args to match create_submesh - #4518
Merged
Merged
Conversation
jhale
added this pull request to stack #4520
September 15, 2026 09:18
jhale
force-pushed
the
jhale/mesh-review-transfer-meshtags-arg-order
branch
from
September 15, 2026 13:03
f687380 to
643744a
Compare
jhale
marked this pull request as ready for review
September 15, 2026 13:05
jhale
force-pushed
the
jhale/mesh-review-transfer-meshtags-arg-order
branch
from
September 15, 2026 13:12
643744a to
8570bb6
Compare
jhale
force-pushed
the
jhale/mesh-review-transfer-meshtags-arg-order
branch
from
September 15, 2026 13:50
8570bb6 to
a1a843c
Compare
jhale
force-pushed
the
jhale/mesh-review-transfer-meshtags-arg-order
branch
from
September 15, 2026 13:59
a1a843c to
6c4e317
Compare
Member
|
I'm a bit worried about this one, as it will be very hard for downstream users to catch (even if it is in the release notes). |
jhale
force-pushed
the
jhale/mesh-review-transfer-meshtags-arg-order
branch
from
September 15, 2026 18:42
6c4e317 to
dc560fa
Compare
jhale
force-pushed
the
jhale/mesh-review-transfer-meshtags-arg-order
branch
from
September 16, 2026 08:16
dc560fa to
1f14993
Compare
chrisrichardson
approved these changes
Sep 16, 2026
jhale
force-pushed
the
jhale/mesh-review-transfer-meshtags-arg-order
branch
from
September 16, 2026 15:19
1f14993 to
8dcab6b
Compare
Member
Author
There is a 'tiny struct trick' in C++ which we can use for one or two rounds of releases to force users to make the switch through the typing system. |
garth-wells
approved these changes
Sep 17, 2026
jhale
force-pushed
the
jhale/mesh-review-transfer-meshtags-arg-order
branch
from
September 17, 2026 06:27
8dcab6b to
e1bed85
Compare
jhale
force-pushed
the
jhale/mesh-review-transfer-meshtags-arg-order
branch
2 times, most recently
from
September 17, 2026 16:39
1592e56 to
04a03f5
Compare
Base automatically changed from
jhale/mesh-review-wp3-boundary-validation
to
main
September 18, 2026 07:51
create_submesh returns (submesh, entity_map, vertex_map, geom_map), but transfer_meshtags_to_submesh took (tags, submesh, vertex_map, cell_map) - vertex/cell swapped relative to how callers just received them, which was the natural mistake the F12-1 validation now catches. Reorders to (tags, submesh, cell_map, vertex_map) so create_submesh's result can be unpacked and passed straight through. Breaking change, no deprecation path. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
jhale
force-pushed
the
jhale/mesh-review-transfer-meshtags-arg-order
branch
from
September 18, 2026 07:51
04a03f5 to
a096cd2
Compare
Member
Author
|
@jorgensd I have another PR which types this, will submit separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create_submesh returns (submesh, entity_map, vertex_map, geom_map), but
transfer_meshtags_to_submesh took (tags, submesh, vertex_map, cell_map)
was the natural mistake the F12-1 validation now catches. Reorders to
(tags, submesh, cell_map, vertex_map) so create_submesh's result can be
unpacked and passed straight through. Breaking change, no deprecation
path.
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Stack created with GitHub Stacks CLI • Give Feedback 💬