Fix/MID-11929 (Regressionin handling of connId constants deserialization type) - #4
Open
matusmacik wants to merge 2 commits into
Open
Fix/MID-11929 (Regressionin handling of connId constants deserialization type)#4matusmacik wants to merge 2 commits into
matusmacik wants to merge 2 commits into
Conversation
- In case of some connId constantds UID, NAME the connId type during deserialization must always be STRING.
- Tests for various use-casses - Refactoring MappingRuleTests class and reusing inner classes.
matusmacik
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce String type for ConnId UID / NAME attributes
forcedConnIdType()inAbstractAttributeBuilderto returnString.classfor__UID__and__NAME__(unless explicitly declared).AbstractAttributeBuilder.JsonBuilder#buildto apply this forced type viaValueTypeOverrideMappingbefore any explicitconnIdTypeoverride.String) is respected even when the OpenAPI schema defines a different native type.ForcedConnIdTypeTestclass with unit tests to verify the supported use-casses.MappingRuleTestand reused the inner static classes for reuse in ForcedConnIdTypeTest .