Add error source-location helpers - #1
Open
johnstone3 wants to merge 1 commit into
Open
Conversation
Connector errors thrown from within Groovy scripts gave no indication of which script or line caused them, making failures hard to diagnose. The location can only be recovered from the exception's own captured stack trace, not the live call stack, since by the time a catch block runs the live stack has already unwound past where the script failed. Revealing internal script paths in error messages is an information-disclosure concern in production, not a performance one, so this stays gated behind DevelopmentMode and only shows up when a developer has opted in. ConnectorExceptions.raiseException() gives connector code one place to build these messages, keeping the format extensible so future fields can be added later without breaking existing messages. Task: 11961
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connector errors thrown from within Groovy scripts gave no indication of which script or line caused them, making failures hard to diagnose.
The location can only be recovered from the exception's own captured stack trace, not the live call stack, since by the time a catch block runs the live stack has already unwound past where the script failed.
Revealing internal script paths in error messages is an information-disclosure concern in production, not a performance one, so this stays gated behind DevelopmentMode and only shows up when a developer has opted in.
ConnectorExceptions.raiseException() gives connector code one place to build these messages, keeping the format extensible so future fields can be added later without breaking existing messages.
Task: 11961