Fix missing/duplicated flying scores - #44
Open
Jonas00000 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Flying scores are now spawned immediately instead of using
SpawnFlyingScoreNextFrame.The original method keeps a reference to a pooled
CutScoreBufferfor one frame.If that buffer is reused before the coroutine resumes, the effect can read another note's score and position.
This causes overlapping or duplicated effects, making one score appear to be missing.
Immediate spawning ensures that the effect is initialized while the buffer still belongs to the correct note.
Related Beat Saber bug:
Meivyn/BeatSaberBugs#26
Testing
Tested for around four hours on Beat Saber 1.44.1.
The problem previously occurred at least twice per map and did not occur again with this patch.