Repository navigation
Conversation
Every R-hub platform failed while installing dependencies: "Can't find package called rWCVPdata". R-hub installs with pak, which doesn't read DESCRIPTION's Additional_repositories. A step before setup-deps in both jobs now adds the drat repository to the R user profile, loading utils first so the platform's own repositories are kept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
BIEN was suggested only for the \dontrun example of the deprecated, unexported NSR_from_coordinates(). It imports RPostgreSQL, which failed to compile on R-hub's Fedora platforms (atlas, nosuggests) for lack of the PostgreSQL headers, stopping both before R CMD check ran. The example now builds its input as a data frame. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
R-hub's nosuggests platform, like CRAN's no-Suggests checks, runs with only Depends, Imports, VignetteBuilder and testthat available, and failed twice: - The tests stopped in setup-nsr.R, which loaded vcr unconditionally. vcr is now set up only when installed, and each test replaying a recorded API response skips itself without it. - The vignette couldn't be rebuilt: its knitr::rmarkdown engine needs rmarkdown, which was only in Suggests. rmarkdown is now also listed in VignetteBuilder, so it's available in these checks. R CMD check --as-cran with _R_CHECK_DEPENDS_ONLY_=true now passes locally. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.
Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.
There was a problem hiding this comment.
🟢 Approval recommended
The focused dependency, test-guard, and documentation changes have no identified blocking issues.
No open issues 🎉
1 file not reviewed
man/NSR_from_coordinates.Rd: Generated file
What changed in this PR
Improves R-hub dependency setup and supports package checks without optional test dependencies.
Changes:
- Adds the rWCVPdata drat repository to both R-hub jobs.
- Makes vcr setup conditional and skips dependent tests when unavailable.
- Replaces BIEN-based examples with inline data and updates vignette builders.
| File | Description |
|---|---|
| tests/testthat/test-NSR.R | Skips without vcr. |
| tests/testthat/test-NSR_version.R | Skips without vcr. |
| tests/testthat/test-NSR_sources.R | Skips without vcr. |
| tests/testthat/test-NSR_simple.R | Skips both examples without vcr. |
| tests/testthat/test-NSR_political_divisions.R | Skips both examples without vcr. |
| tests/testthat/test-NSR_data_dictionary.R | Skips both examples without vcr. |
| tests/testthat/test-NSR_citations.R | Skips without vcr. |
| tests/testthat/setup-nsr.R | Configures vcr only when installed. |
| R/NSR_from_coordinates.R | Simplifies the documented example. |
| man/NSR_from_coordinates.Rd | Synchronizes the help example. |
| DESCRIPTION | Removes BIEN and adds rmarkdown as a vignette builder. |
| .github/workflows/rhub.yaml | Configures drat before dependency installation. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.