You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is the error that got NSR archived from CRAN: on the Windows check
machines the API could not be reached, NSR_metadata() assigned NULL results
into a list and then named three elements, breaking the examples and the
vignette. It now gives a message and returns NULL, stopping after the first
failed request.
nsr_core()'s exists() checks no longer look outside the function, so a
same-named object in the user's workspace can't be mistaken for a reply.
New tests put every exported API function through an unreachable API, an
HTTP error, an empty reply and no internet access, with the request mocked.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rWCVP was archived on CRAN on 2025-11-28, so CRAN can't install it. It was
only a fallback source for the WGSRPD polygons that rWCVPdata provides, and
rWCVPdata is available through Additional_repositories.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Same workflow as RTNRS and RGNRS, plus the drat repository for rWCVPdata.
Adds the status badge to the README.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dev/release_checks.R follows glyospalettes': docs and figures, the
--as-cran incoming checks, URL and spelling checks, tarball size, and the
remote builders, run section by section before a CRAN submission. It adds
the API-down checks that got 0.1.0 archived and all three Windows
builders. dev/ is in .Rbuildignore.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The reason will be displayed to describe this comment to others. Learn more.
⚠️Code review skipped — your organization has no extra usage available to pay for this review.
If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.
Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.
R CMD check on GitHub Actions warned "Missing or unexported object:
'TNRS::TNRS_local'" and "Missing object imported by a ':::' call:
'TNRS:::tnrs_cache_dir'". Both exist only in TNRS 0.4.0; CRAN has 0.3.6,
so CRAN's checks would warn the same way. The local check passed only
because TNRS 0.4.0 is installed here.
TNRS_local() is now looked up at run time, with a clear error naming the
version needed when the installed TNRS lacks it. TNRS's cache directory
is computed from TNRS's own rule instead of calling its unexported
tnrs_cache_dir(). R CMD check now passes against TNRS 0.3.6.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
The new regression test can overwrite and delete an existing object in the developer’s workspace.
No open issues 🎉
1 previously missed issue
In code that hasn't changed since last review
devtools::test() overwrites and removes existing global results_json
tests/testthat/test-NSR_api_failure.R:69
When devtools::test() runs in a session with an existing global results_json, this overwrites its value and the deferred rm() removes the binding. The developer's original object is lost. Save and restore the previous value, and remove the temporary binding only if none existed before the test.
Under devtools::test(), the test overwrote a developer's own
results_json and then removed it. It now puts back what was there, and
removes the binding only if there was none.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.