Repository navigation
Conversation
Takes the label as a prop to let the same burst carry other short labels. No visual change.
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
The info server lists payment types per direction with an endIsoDate, and the quote card shows a "New" burst until that date. Best Rate keeps the slot when both apply.
j0ntz
force-pushed
the
jon/ramps-new-badge
branch
from
November 1, 2026 17:31
cbf2b58 to
d80f003
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Asana task
Shows a "New" burst on ramp payment methods that the info server lists as new, until each entry's
endIsoDatepasses. It reuses the Best Rate burst with a different label:BestRateBadgebecomesBurstBadgewith alabelprop.The config is
exchangeInfo.{buy,sell}.newPaymentTypes, keyed by payment type. A card has one burst slot, and Best Rate keeps it when a method is both best and new. A missing or invalid date shows no badge. The expiry is checked at render.Servicesreloads exchange info whenever an info rollup lands. The 10-minute refresher fires at mount, and on a slow info server answer it runs before the launch rollup exists.updateExchangeInfoskips the dispatch when the payload is unchanged, because the Send scene re-quotes on a newexchangeInfoidentity and rollups repeat every 5 minutes.Testing injected the config through a local proxy in front of the production info server, because the field is not live yet. For the late-rollup frame the proxy held the rollup answer for 20 seconds. The answer landed after login, and the list opened 53 seconds later. Only the buy direction was driven on the simulator for these frames. Sell shares the same code path and has unit test coverage.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
EdgeApp/edge-info-server#169 adds the config field. This PR passes without it, since a missing field means no badge.
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Tested on the iOS simulator only.
Test evidence
d80f003Badge new ramp payment methods
2026-11-01
1. new badge on configured payment methods
2. best rate wins when a method is also new
3. expired date shows no new badge
4. invalid date shows no new badge
1. c4 new after late rollup