Repository navigation
Conversation
Next stays available for an amount above the balance and asks for quotes with allowInsufficientFunds. The confirmation scene warns and disables the slider on a quote the wallet cannot pay for, and prefers a funded quote when one exists. A missing fee on such a quote reads N/A rather than zero.
A sell amount above the balance no longer stops the quote request, so the option scene lists quotes. The amount scene warns instead of showing an error, and pressing a quote the wallet cannot pay for shows a toast rather than opening the provider. A quote is unfunded when its crypto amount exceeds the balance, which also covers amounts entered in fiat.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
j0ntz
added
the
awaiting-dep-publish
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Asana task
Users could not shop for swap or sell quotes until they had moved funds into Edge: an amount above the wallet balance hid Next. Quotes now surface at any amount, and the transaction is blocked with a warning.
Swap
allowInsufficientFunds(never for a max amount).Sell
Buy is unchanged. Wallet-less shopping is out of scope, since a zero-balance wallet is enough to shop.
A shopping quote creates a real provider order, the same as a funded quote does, including Houdini's one-order-per-minute slot.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Test evidence
6e0a911Quote sells above the wallet balance
2026-11-01
1. exchange amount above balance keeps next
2. swap quote warns fee row na slider locked
3. swap providers quote short amount
4. sell amount above balance keeps next
5. sell quotes surface with warning
6. sell quote press blocked with toast
7. funded swap quote can slide
8. funded swap success
9. zero balance wallet amount keeps next
10. zero balance swap quote warns slider locked
11. zero balance sell amount keeps next
12. zero balance sell quotes surface with warning
13. zero balance sell quote press blocked with toast
Awaiting publish: edge-core-js@2.55.0 (npm latest when applied: 2.54.0)