Repository navigation
Conversation
fetchSwapQuote asked the source wallet for its spendable balance, using an XRP dummy address, before checking that the pair is supported. For a non-XRP source the engine fails that call: piratechain throws InsufficientFundsError when nothing is spendable and other chains reject the address. Core ranks InsufficientFundsError above every SwapCurrencyError, so a swap no provider supports told the user their funds were short. Move the pair gates ahead of the balance query. All three go together so same-asset XRP swaps and two-wallet requests also fail on what is wrong with them rather than on the balance.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Description
Asana task
XRP DEX asked the source wallet for its spendable balance before checking whether it supports the pair. A non-XRP engine can fail that query with
InsufficientFundsError, orPendingFundsErrorbefore it finishes syncing. Core ranks those above every other partner'sSwapCurrencyError. An unsupported pair such as ARRR to ETH could therefore tell the user "Insufficient Funds" when the real answer is that no exchange supports the pair.The change moves the three pair checks (XRP wallets only, same wallet, different assets) out of
fetchSwapQuoteInnerand ahead ofgetMaxSpendableinfetchSwapQuote. Quoting behavior for supported XRP pairs does not change, and a supported pair the wallet cannot afford still reports insufficient funds.rankErrorin core stays as is: the ranking is right, and the error from this plugin was wrong.Testing
test/xrpDex.test.tsis new. 5 of its 6 cases fail on the old code; all 6 pass now.xrpdex gave swap error: InsufficientFundsError, card "Insufficient Funds". New plugin:SwapCurrencyError, card "No enabled exchanges support ARRR to ETH."95566ca759fc5272060ce1da9fad31fad35aecc66c7ec42beeef7ceb64cd8cf3.Test evidence
b55a6e4Fix XRP DEX unsupported pair error
2026-11-01
2. before arrr max insufficient
1. after arrr max error
4. xrp dex swap success